Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: Rename viper to vyper #627

Merged
merged 5 commits into from Jan 30, 2018
Merged

Documentation: Rename viper to vyper #627

merged 5 commits into from Jan 30, 2018

Conversation

jacqueswww
Copy link
Contributor

@jacqueswww jacqueswww commented Jan 10, 2018 •
edited

- What I did

Part of #501.

  • Renamed binary to vyper.
  • Renamed all occurences of viper to vyper.

- How I did it

make html

- How to verify it

Make the docs and browser through them.

- Description for the changelog

Renamed all occurences of viper to vyper in the documentation.

- Cute Animal Picture

mattermat
mattermat suggested changes Jan 10, 2018
View reviewed changes
docs/index.rst Outdated
@@ -48,7 +48,7 @@ Following the principles and goals, Viper **does not** provide the following fea
Compatibility-breaking Changelog
********************************

* **2017.12.25**: Change name from Viper to Vyper
* **2017.12.25**: Change name from Vyper to Vyper
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be modified.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True, I got a bit carried away perhaps ;) should I remove it completely or just state that the command was renamed to vyper?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the statement that the rename occuring, this is a major breaking change

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm agreed with fubuloubu! :)

@mattermat
Copy link

mattermat commented Jan 10, 2018 •
edited

Furthermore, you have to change also the occurrencies in setup.py in order to pass CI tests. Or remove renaming of bin/viper and bin/viper-bin, that is out of the scope of the renaming occurencies in the documentation

@jacqueswww
Copy link
Contributor Author

@mattermat will do. Since I am renaming it here, I'll make the same changes here. Also the module needs renaming - will do that next ;)

@fubuloubu fubuloubu mentioned this pull request Jan 19, 2018
Closed
@fubuloubu
Copy link
Member

@DavidKnott needs a pre beta tag

@DavidKnott
Copy link
Contributor

DavidKnott commented Jan 27, 2018 •
edited

@jacqueswww Rebase and I'm happy to merge it 😄

@jacqueswww
Copy link
Contributor Author

@DavidKnott updated.

fubuloubu
fubuloubu approved these changes Jan 29, 2018
View reviewed changes
Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM

@DavidKnott DavidKnott merged commit 5f8468a into vyperlang:master Jan 30, 2018
@fubuloubu
Copy link
Member

Woot! Is this task totally complete now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fubuloubu fubuloubu fubuloubu approved these changes

@mattermat mattermat mattermat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jacqueswww @mattermat @fubuloubu @DavidKnott