Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENS: option to use custom registry addresses #3010

Open
sohkai opened this issue Aug 7, 2019 · 0 comments

Comments

@sohkai
Copy link

commented Aug 7, 2019

Description

The current web3.eth.ens module only supports the official ENS registries on various networks, but there are some custom ENS deployments (especially on testnets) that users may want to resolve from.

Expected behavior

Upon creating the ENS module, the user could pass an option to specify the registry address (e.g. see ethereum-ens's options).

Actual behavior

The ENS module self-selects a registry address based on the current network, without giving the user a chance to override it.

Versions

  • web3.js: v1.2.1 and v2

It would be ideal for this to be included in both v1 and v2, but if we'd like to avoid new features to v1, it would make sense to add it only to v2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.