-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BigNumber dependency #904
Comments
+1 Same here. Can't install |
+1 Same problem we are facing. |
this should fix the issue, not sure if bignumber updates have broken anything on web3.js but it seems to work. I'm going to run more tests to be sure. |
Ironically, the top recommended comment to "Ethereum is impossible to get started" is |
hey, just came here to say I ran into the same issue. Is there a workaround until this patch is pushed? |
@theporpoise one way is to change your package file to use the fixed version. I'm using this at the moment |
thanks @shayanb ! |
I was trying to fix this after checking #439 but indeed the repo is not available anymore. |
Modify package.json as below
|
Looks like PR #905 that was merged fixed the issue in the |
Something like this? #906 |
Can someone please release the hotfix on npm? |
Yep my issue is with npm as well. |
This is currently breaking testrpc as well. |
Seems like marek did remove bignumber.js from his repo |
Having issues with truffle ATM as well. |
I merged @orlandoc01 PR and published 0.19.1, but i can't get the meteor version uploaded, something is broken on the meteor servers. |
@frozeman I'm good with develop in my package.json but I can't get truffle to grab it's deps correctly - I'll make the changes to truffle to use dev. Thanks for moving quickly on this. |
thanks @orlandoc01 for the PR and thanks @frozeman for moving quickly! |
Ok got 0.19.11 published on meteor as well. |
@ALL i switched to the older bignum version with lookahead disabled, which is necessary for web3.js working in the geth console. |
web3 npm is working again. ethereumjs-testrpc however has the same issue as described above. |
Shouldn't the fix involve updating all bignumber.js deps to use the master repro here: https://github.com/MikeMcl/bignumber.js/ ? |
sry guys for breaking that. Thanks to @iurimatias the repo is back up and even old versions of |
I wonder why not use the original repo? And why not use npm to manage the dependency? |
@xwartz because its a degradation of a feature, but necessary so it runs in the otto VM. web3.js 1.0 will not have big number.js at all |
@frozeman thanks for replying. I have seen bignumber.js as devDependency in web3.js 1.0. That's greate! |
I am encountering this same issue again. Anyone else ?
EDIT: |
I just rebuilt from version web3.js v1 beta 29 a few nights ago and so far so good. |
Can the |
When using bower and installing
|
Fork the bignumber repo. Upload it to npm. Point the package.json from web3 to that repo. Republish web3 on npm. cloning from the development branch is not working. |
The dependency listed here https://github.com/ethereum/web3.js/blob/develop/package.json#L11 points to a github repo that no longer exists. Until this dependency is resolved, I can no longer install and use this library
The text was updated successfully, but these errors were encountered: