Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BigNumber dependency #904

Closed
orlandoc01 opened this issue Jun 23, 2017 · 33 comments
Closed

BigNumber dependency #904

orlandoc01 opened this issue Jun 23, 2017 · 33 comments

Comments

@orlandoc01
Copy link
Contributor

The dependency listed here https://github.com/ethereum/web3.js/blob/develop/package.json#L11 points to a github repo that no longer exists. Until this dependency is resolved, I can no longer install and use this library

@maraoz
Copy link

maraoz commented Jun 23, 2017

+1

Same here. Can't install web3

@obale
Copy link
Contributor

obale commented Jun 23, 2017

+1

Same problem we are facing.

@alankritjoshi
Copy link

alankritjoshi commented Jun 23, 2017

How is 1.0 handling BigNumber (devdependency) 4.0.0? Can we backport the changes to fix this issue? Where does bn.js come into picture?

@shayanb
Copy link
Contributor

shayanb commented Jun 23, 2017

this should fix the issue, not sure if bignumber updates have broken anything on web3.js but it seems to work. I'm going to run more tests to be sure.

#905

@highruned
Copy link

Ironically, the top recommended comment to "Ethereum is impossible to get started" is use embark which has dep on web3 which doesn't install due to this 😂
https://www.reddit.com/r/ethereum/comments/6iorba/getting_started_on_ethereum_is_impossible_my/?st=j4aee9mk&sh=54e30401

@theporpoise
Copy link

hey, just came here to say I ran into the same issue. Is there a workaround until this patch is pushed?

@shayanb
Copy link
Contributor

shayanb commented Jun 23, 2017

@theporpoise one way is to change your package file to use the fixed version. I'm using this at the moment "web3": "https://github.com/shayanb/web3.js#develop" in package.json

@theporpoise
Copy link

thanks @shayanb !

@nicoschtein
Copy link

I was trying to fix this after checking #439 but indeed the repo is not available anymore.

@wangjia184
Copy link

Modify package.json as below

{
  "dependencies": {
    "web3": "github:shayanb/web3.js#develop"
  }
}

@orlandoc01
Copy link
Contributor Author

orlandoc01 commented Jun 24, 2017

Looks like PR #905 that was merged fixed the issue in the develop branch. However, since the situation requires a hotfix, there should be a fix made to the master branch and probably a new patch release, unless the team is planning on releasing v1.0 soon (since it appears to be fixed there)? Otherwise the published npm module is still broken and everyone depending on it through an npm installation can not use this.

@orlandoc01
Copy link
Contributor Author

Something like this? #906

@MitchK
Copy link

MitchK commented Jun 24, 2017

Can someone please release the hotfix on npm?

@analogrytm
Copy link

Yep my issue is with npm as well.

@OR13
Copy link

OR13 commented Jun 24, 2017

This is currently breaking testrpc as well.

https://travis-ci.org/ethereumjs/testrpc/jobs/246462784

trufflesuite/ganache-cli-archive#332

@frozeman
Copy link
Contributor

Seems like marek did remove bignumber.js from his repo

@adonley
Copy link
Contributor

adonley commented Jun 24, 2017

Having issues with truffle ATM as well.

@frozeman
Copy link
Contributor

I merged @orlandoc01 PR and published 0.19.1, but i can't get the meteor version uploaded, something is broken on the meteor servers.
@adonley you still have the issues with the current develop?

@adonley
Copy link
Contributor

adonley commented Jun 24, 2017

@frozeman I'm good with develop in my package.json but I can't get truffle to grab it's deps correctly - I'll make the changes to truffle to use dev. Thanks for moving quickly on this.

@MitchK
Copy link

MitchK commented Jun 24, 2017

thanks @orlandoc01 for the PR and thanks @frozeman for moving quickly!

@frozeman
Copy link
Contributor

Ok got 0.19.11 published on meteor as well.

@frozeman
Copy link
Contributor

@ALL i switched to the older bignum version with lookahead disabled, which is necessary for web3.js working in the geth console.
Can you please test the develop branch and tell me if its working for you guys?

@analogrytm
Copy link

web3 npm is working again.

ethereumjs-testrpc however has the same issue as described above.

@imosdevteam
Copy link

Shouldn't the fix involve updating all bignumber.js deps to use the master repro here: https://github.com/MikeMcl/bignumber.js/ ?

@debris
Copy link
Contributor

debris commented Jun 25, 2017

sry guys for breaking that. Thanks to @iurimatias the repo is back up and even old versions of web3.js should be working

@xwartz
Copy link

xwartz commented Jun 27, 2017

I wonder why not use the original repo? And why not use npm to manage the dependency?
I saw the only different code is this commit. I think we should create a PR to the original repo.

@frozeman
Copy link
Contributor

frozeman commented Jun 27, 2017

@xwartz because its a degradation of a feature, but necessary so it runs in the otto VM.

web3.js 1.0 will not have big number.js at all

@xwartz
Copy link

xwartz commented Jun 28, 2017

@frozeman thanks for replying. I have seen bignumber.js as devDependency in web3.js 1.0. That's greate!

@Clement-Bresson
Copy link

Clement-Bresson commented Feb 15, 2018

I am encountering this same issue again. Anyone else ?
npm version : 5.6.0 (lastest)

npm install web3 command stays stuck at http-https@1.0.0.....

EDIT:
It was actually only an error with my network. I just changed network and everything worked.
It was working great for other packages but not this one. Could be good to know for something having the same issue.

@analogrytm
Copy link

I just rebuilt from version web3.js v1 beta 29 a few nights ago and so far so good.

@forestbelton
Copy link

Can the bignumber.js-nolookahead.git version be pinned to a particular git SHA?

@nivida nivida closed this as completed Aug 9, 2018
@DurandA
Copy link

DurandA commented Nov 13, 2018

When using bower and installing web3@1.0.0-beta.34, this is still an issue:

bower web3#1.0.0-beta.34        cached https://github.com/ethereum/ethereum.js.git#1.0.0-beta.34
bower web3#1.0.0-beta.34      validate 1.0.0-beta.34 against https://github.com/ethereum/ethereum.js.git#1.0.0-beta.34
bower bn.js#>=4.11.6         ENOTFOUND Package bn.js not found

@nival999
Copy link

nival999 commented Nov 17, 2018

Fork the bignumber repo. Upload it to npm. Point the package.json from web3 to that repo. Republish web3 on npm. cloning from the development branch is not working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests