Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
fix websocket provider basic auth handling #2593
Previous handling of basic authentication credentials created base64 buffer concatenated user/pass. Should be creating buffer of base64 encoded string.
url-parse used always includes
NOTE: Fix does not address the lack of testing around the URL.auth object
I was unable to test against the ethereum test network because I couldn't figure out how to load the module locally (I am brand new to node).
Type of change