New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional padding argument for fromUtf8 and fromAscii functions #375

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@ruchevits
Member

ruchevits commented Jan 19, 2016

No description provided.

@chriseth

This comment has been minimized.

Contributor

chriseth commented Jan 19, 2016

Adding padding is an operation that is different from decoding and thus I think it should be implemented in its own function. This portion of web3 is currently undergoing redesign anyway. Please add suggestions there:
#372
#363

@frozeman

This comment has been minimized.

Member

frozeman commented Aug 9, 2017

We do expose now ABI encoding functions in web3 1.0 (http://web3js.readthedocs.io/en/1.0/web3-eth-abi.html#encodeparameter). So i assume this PR is now obsolete. If you still think its a good idea, please open a new issue. Thanks for your contribution anyway, tho.

@frozeman frozeman closed this Aug 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment