New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting personal.importRawKey, personal.sign, personal.ecRecover from go-ethereum to web3.js #565

Merged
merged 3 commits into from May 9, 2017

Conversation

Projects
None yet
5 participants
@peculiarity
Contributor

peculiarity commented Feb 27, 2017

No description provided.

@peculiarity peculiarity changed the title from Porting personal.importRawKey from go-ethereum to web3.js to Porting personal.importRawKey, personal.sign, personal.ecRecover from go-ethereum to web3.js Feb 27, 2017

@kumavis

This comment has been minimized.

Show comment
Hide comment
@kumavis

kumavis Feb 27, 2017

Member

Looks good to me - we are supporting personal_sign and personal_ecRecover in MetaMask

Member

kumavis commented Feb 27, 2017

Looks good to me - we are supporting personal_sign and personal_ecRecover in MetaMask

@peculiarity

This comment has been minimized.

Show comment
Hide comment
@peculiarity
Contributor

peculiarity commented Feb 28, 2017

@danfinlay

This comment has been minimized.

Show comment
Hide comment
@danfinlay

danfinlay Mar 1, 2017

Looks good to me - we are supporting personal_sign and personal_ecRecover in MetaMask

Well, we will be supporting them later today.

danfinlay commented Mar 1, 2017

Looks good to me - we are supporting personal_sign and personal_ecRecover in MetaMask

Well, we will be supporting them later today.

@danfinlay

This comment has been minimized.

Show comment
Hide comment
@danfinlay

danfinlay Mar 16, 2017

Any idea when we can expect this on the main release?

danfinlay commented Mar 16, 2017

Any idea when we can expect this on the main release?

@peculiarity

This comment has been minimized.

Show comment
Hide comment
@peculiarity

peculiarity Mar 16, 2017

Contributor

I don't think anyone maintains this project..

Contributor

peculiarity commented Mar 16, 2017

I don't think anyone maintains this project..

@danfinlay

This comment has been minimized.

Show comment
Hide comment
@danfinlay

danfinlay Mar 16, 2017

@frozeman does, I thought.

danfinlay commented Mar 16, 2017

@frozeman does, I thought.

@danfinlay

This comment has been minimized.

Show comment
Hide comment
@danfinlay

danfinlay Mar 16, 2017

I'm currently drafting a blog post about this new feature in MetaMask, it would be great to not have to have a note about how web3 hasn't implemented it yet.

danfinlay commented Mar 16, 2017

I'm currently drafting a blog post about this new feature in MetaMask, it would be great to not have to have a note about how web3 hasn't implemented it yet.

@peculiarity

This comment has been minimized.

Show comment
Hide comment
@peculiarity

peculiarity Mar 16, 2017

Contributor

At least if it's not maintained anymore, we can have a fork and start maintaining it.

Contributor

peculiarity commented Mar 16, 2017

At least if it's not maintained anymore, we can have a fork and start maintaining it.

@danfinlay

This comment has been minimized.

Show comment
Hide comment
@danfinlay

danfinlay Mar 16, 2017

I think Fabian is on a vacation or something (based on his commit history), I'm sure he'll be back soon.

danfinlay commented Mar 16, 2017

I think Fabian is on a vacation or something (based on his commit history), I'm sure he'll be back soon.

@frozeman

This comment has been minimized.

Show comment
Hide comment
@frozeman

frozeman May 9, 2017

Member

Yeah, sorry for the delay. i was on vacation and very busy on the 1.0 branch, so i didn't put much attention to develop since a while. Merged a bunch now..

Member

frozeman commented May 9, 2017

Yeah, sorry for the delay. i was on vacation and very busy on the 1.0 branch, so i didn't put much attention to develop since a while. Merged a bunch now..

@frozeman frozeman merged commit a24df28 into ethereum:develop May 9, 2017

@peculiarity

This comment has been minimized.

Show comment
Hide comment
@peculiarity

peculiarity May 9, 2017

Contributor

@frozeman cheers

Contributor

peculiarity commented May 9, 2017

@frozeman cheers

frozeman added a commit that referenced this pull request May 9, 2017

Merge develop and bump version (#870)
* bumped version (#865)

* validate number of args to solidity functions (#866)

* Fix for "filterCreationErrorCallback is not a function" Error #552 (#861)

* Missing some checks in order to verify if given value is an object (#568)

* make sure the old behaviour is valued in toHex

* Porting personal.importRawKey, personal.sign, personal.ecRecover from go-ethereum to web3.js (#565)

* Porting personal.importRawKey

* Porting personal.sign

* Porting personal.ecRecover

* Export padLeft and padRight as functions of web3 (#848)

I'm working with `bytes12` and it's useful to have these two functions in the web3 object for formatting.

* bumped version

* fixed lint

* new versions file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment