Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Optional for typing on eth.py #1668

Merged
merged 2 commits into from Jun 10, 2020
Merged

Use Optional for typing on eth.py #1668

merged 2 commits into from Jun 10, 2020

Conversation

Uxio0
Copy link
Contributor

@Uxio0 Uxio0 commented Jun 10, 2020 •
edited

What was wrong?

Mypy complaining about using None in functions where typing was set to non None values.

How was it fixed?

  • Optional[type] is used for nullable arguments
  • Fixed formatting of default arguments when using type argument: type = default, with spaces around =

Todo:

  • Fix another files

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

wolovim
wolovim approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@wolovim wolovim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes; just needs a newsfragment, which I'll get to shortly.

@wolovim wolovim merged commit 38df51a into ethereum:master Jun 10, 2020
@Uxio0 Uxio0 mentioned this pull request Jun 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolovim wolovim wolovim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Uxio0 @wolovim