Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding an advanced example of events, eth_getLogs and JSON-RPC pitfalls #1910

Merged
merged 4 commits into from Mar 19, 2021

Conversation

miohtama
Copy link
Contributor

What was wrong?

Documentation did not cover the pitfalls of how to fetch events over eth_getLogs.

How was it fixed?

Super comprehensive example code in examples.rst.

Cute Animal Picture

Art by Hayley Jane Wakenshaw

             /)  (\
        .-._((,~~.))_.-,
         `=.   99   ,='
           / ,o~~o. \
          { { .__. } }
           ) `~~~\' (
          /`-._  _\.-\
         /         )  \
       ,-X        #   X-.
hjw   /   \          /   \
     (     )| |  | |(     )
      \   / | |  | | \   /
       \_(.-( )--( )-.)_/
       /_,\ ) /  \ ( /._\
           /_,\  /._\


@miohtama miohtama changed the title Adding an advanced example of eth_getLogs consumption Adding an advanced example of events, eth_getLogs and JSON-RPC pitfalls Mar 14, 2021
@wolovim
Copy link
Member

wolovim commented Mar 14, 2021

thanks a ton for this @miohtama! will give it a proper read tomorrow.

@wolovim wolovim force-pushed the miohtama/advanced-events-example branch from d5258da to c602587 Compare March 19, 2021 22:59
@wolovim wolovim merged commit b5ca8cb into ethereum:master Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants