Classes inheriting from Web3 did not attach modules appropriately
#2587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fselmo
force-pushed
the
bugfix-web3-inheritance
branch
2 times, most recently
from
bbaf880
to
f6192ed
Compare
* Bug fix: On the first run of ``attach_modules()``, ``w3`` should be ``None`` and the ``parent_module`` is the ``Web3`` class. We should look for this condition and set ``w3 = parent_module``. We couldn't use a simple ``isinstance()`` due to a circular import, but we can import it locally if ``w3`` is ``None``. This allows classes to inherit from ``Web3`` without needing to validate that the class name is ``Web3``. This also allows modules to not need to set a ``w3`` if they don't need one, as the older code was intended to do.
fselmo
force-pushed
the
bugfix-web3-inheritance
branch
from
f6192ed
to
9acc3a0
Compare
fselmo
commented
Jul 26, 2022
| @@ -70,13 +70,13 @@ def test_implicitcontract_transact_default(web3, math_contract, get_transaction_ | |||
| assert is_integer(start_count) # Verify correct type | |||
| # When a function is called that defaults to transact | |||
| blocknum, starting_txns = get_transaction_count("pending") | |||
| with pytest.warns(DeprecationWarning, | |||
| match='deprecated in favor of classic contract syntax') as warnings: | |||
| with pytest.warns( | |||
There was a problem hiding this comment.
These tests were looking for a particular number of warnings which can't be sustainable as our dependencies will eventually issue warnings (as eth-abi did which broke these tests).
This was referenced Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
closes #2586
How was it fixed?
Web3locally in order to avoid circular import. This allows us to make the check we wanted to in the first place which is to check that theparent_moduleis an instance of theWeb3class (or inherits from it) whenw3isNone.Todo:
Cute Animal Picture