Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept list or string for filter_param address #1005

merged 1 commit into from Aug 20, 2018


Copy link

@dylanjw dylanjw commented Aug 16, 2018

What was wrong?

Related to Issue #999

How was it fixed?

The abi type for the filte address parameter was changed from address to address[], and an additional formatting layer was added to wrap single address strings in a list.
A new middleware was added for formatting method parameters prior to other formatting steps such as abi formatting and pythonic formatting.

Cute Animal Picture


Along with wrapping address in a list in filter parameter
@dylanjw dylanjw force-pushed the address-to-list-filter-params branch from d2190d2 to 3e8f2e4 Compare August 16, 2018 18:54
Copy link

@carver carver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@dylanjw dylanjw merged commit f1e8e91 into ethereum:master Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants