Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD initial support #1008

Merged
merged 3 commits into from Aug 22, 2018
Merged

FreeBSD initial support #1008

merged 3 commits into from Aug 22, 2018

Conversation

rayrapetyan
Copy link

What was wrong?

FreeBSD OS wasn't supported

How was it fixed?

Added necessary checks and provided dev installation instructions in readme file.

Copy link
Collaborator

@carver carver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! If you're interested, a circle test running in a FreeBSD container would help make sure that support doesn't break silently in the future.

@rayrapetyan
Copy link
Author

@carver, thanks! Do you mean tox -e smth? Any idea how to pass

--global-option=build_ext --global-option='-I/usr/local/include'

into tox properly?

@voith
Copy link
Contributor

voith commented Aug 22, 2018

@carver Doesn't seem like circleCI supports free bsd: https://hub.docker.com/r/circleci/python/tags/

Do you mean tox -e smth? Any idea how to pass

@rayrapetyan I think @carver wants to have the test suite run on a FreeBSD container in circleCI:
for eg: we have some code running on jessie:

- image: circleci/python:3.5-jessie

@carver
Copy link
Collaborator

carver commented Aug 22, 2018

Doesn't seem like circleCI supports free bsd

Thanks for checking that @voith ! That's exactly what I had in mind. Nothing more to add to this PR, then.

@carver carver merged commit e1e63ac into ethereum:master Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants