Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all used datastructures from utils module #1038

merged 2 commits into from Sep 3, 2018


Copy link

@Exef Exef commented Sep 2, 2018

What was wrong?

As discussed in #1033, web3.utils.datastructures are used to type checks and shouldn't be treated as internal.

How was it fixed?

I moved the from internal utils module to the public one. I wonder if I should be contained in a separate module instead of the top one.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link

The failing test is actually due to us querying the live token contract for the Unicorn tokens. Wondering if you can go and update that line to be 2039 for now until we come up with a better solution to still retain the example since I think it's a useful one, but to get things working for now.

Copy link

I went ahead and did the update. good to go when tests ✔️

@pipermerriam pipermerriam merged commit 0605962 into ethereum:master Sep 3, 2018
@Exef Exef deleted the exef/export-datastructures branch September 4, 2018 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants