fixed faulty dict access syntax which causes an attribute error #1040

amirbaer · Sep 2, 2018

What was wrong?

Related to Issue #1039

How was it fixed?

By fixing the syntax (as detailed in issue #1039).
I could not think of any other possible implications.

Cute Animal Picture

pipermerriam · Sep 3, 2018

doctest failure is unrelated and was fixed in #1038

pipermerriam · Sep 3, 2018

pipermerriam reviewed Sep 3, 2018

View changes

pipermerriam · Sep 3, 2018

web3/contract.py

@@ -1416,7 +1416,7 @@ def parse_block_identifier(web3, block_identifier):
    elif block_identifier in ['latest', 'earliest', 'pending']:
        return block_identifier
    elif isinstance(block_identifier, bytes) or is_hex_encoded_block_hash(block_identifier):
-        return web3.eth.getBlock(block_identifier).number


cc @dylanjw @carver @voith just in case you don't see this. This is a good example of why we should be as diligent as possible to not assume the AttributeDict API is usable within our own web3 apis. Forgive me for preaching to the choir if you're already aware.

FWIW, replacing all the middlewares as the user did in #1039 is almost definitely not what they wanted to do. There will be a lot of things that work incorrectly, like: fields won't be converted to and from python native types. I'm not suggesting that we should encourage attribute syntax, but this is only one of many things that will work in unexpected ways if the user drops all the middleware.

fixed faulty dict access syntax which causes an attribute error

Loading status checks…

ec90c45

ethereum/web3.py

fixed faulty dict access syntax which causes an attribute error #1040

amirbaer commented Sep 2, 2018

This comment has been minimized.

pipermerriam commented Sep 3, 2018

pipermerriam merged commit `38b0303` into ethereum:master Sep 3, 2018
40 of 41 checks passed

40 of 41 checks passed

pipermerriam reviewed Sep 3, 2018

View changes

This comment has been minimized.

This comment has been minimized.

ethereum/web3.py

Join GitHub today

fixed faulty dict access syntax which causes an attribute error #1040

Conversation

amirbaer commented Sep 2, 2018

What was wrong?

How was it fixed?

Cute Animal Picture

This comment has been minimized.

pipermerriam commented Sep 3, 2018

Hide details View details pipermerriam merged commit 38b0303 into ethereum:master Sep 3, 2018 40 of 41 checks passed

40 of 41 checks passed

pipermerriam reviewed Sep 3, 2018 View changes

This comment has been minimized.

pipermerriam Sep 3, 2018

This comment has been minimized.

carver Sep 3, 2018

pipermerriam merged commit `38b0303` into ethereum:master Sep 3, 2018
40 of 41 checks passed

pipermerriam reviewed Sep 3, 2018

View changes