Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ethPM] Update deployments to work when only abi available #1417

Merged

Conversation

@njgheorghita
Copy link
Contributor

@njgheorghita njgheorghita commented Aug 9, 2019

What was wrong?

Currently ethpm.deployments.get_instance() generates a contract factory for each deployment. This will break if manifest does not contain deployment_bytecode for the corresponding contract type. It doesn't seem reasonable to expect a manifest to know the deployment bytecode for every deployment (for example, manifests generated from etherscan uris will have a deployments without deployment bytecode).

ethpm.deployments.get_instance() was updated to generate contract instances rather than factories for each deployment, requiring only the necessary abi data to successfully construct a contract instance.

Cute Animal Picture

image

@njgheorghita njgheorghita requested a review from pipermerriam Aug 9, 2019
@njgheorghita njgheorghita merged commit 01380b5 into ethereum:master Aug 10, 2019
28 checks passed
Loading
@njgheorghita njgheorghita deleted the ethpm-deployments-refactor branch Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants