Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ethPM] Add expression begin/close chars to package name regex #1418

Merged
merged 2 commits into from Aug 12, 2019

Conversation

@njgheorghita
Copy link
Contributor

@njgheorghita njgheorghita commented Aug 12, 2019

What was wrong?

Package name regex expression needs expression beginning/closing chars (^/$) to correctly validate package names.

Cute Animal Picture

image

@njgheorghita njgheorghita changed the title Add expression begin/close chars to package name regex [ethPM] Add expression begin/close chars to package name regex Aug 12, 2019
Copy link
Member

@pipermerriam pipermerriam left a comment

Strikes me as something that could have a test added to validate whatever case this fixes.

Loading

@njgheorghita
Copy link
Contributor Author

@njgheorghita njgheorghita commented Aug 12, 2019

@pipermerriam Definitely, a little suspicious about how it went this long without getting a test but it's there now.

Loading

Copy link
Member

@pipermerriam pipermerriam left a comment

👍

(if you didn't, you should verify that the expected tests do indeed fail without this patch before merging to be extra sure everything is behaving as expected)

Loading

@njgheorghita njgheorghita merged commit 4b146df into ethereum:master Aug 12, 2019
28 checks passed
Loading
@njgheorghita njgheorghita deleted the ethpm-fix-regex branch Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants