Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ethPM] Add expression begin/close chars to package name regex #1418

Merged
merged 2 commits into from Aug 12, 2019

Conversation

@njgheorghita
Copy link
Contributor

commented Aug 12, 2019

What was wrong?

Package name regex expression needs expression beginning/closing chars (^/$) to correctly validate package names.

Cute Animal Picture

image

@njgheorghita njgheorghita changed the title Add expression begin/close chars to package name regex [ethPM] Add expression begin/close chars to package name regex Aug 12, 2019

@njgheorghita njgheorghita force-pushed the njgheorghita:ethpm-fix-regex branch from 2d5877b to 8ac9ca1 Aug 12, 2019

@pipermerriam
Copy link
Member

left a comment

Strikes me as something that could have a test added to validate whatever case this fixes.

@njgheorghita njgheorghita force-pushed the njgheorghita:ethpm-fix-regex branch from 06ab5ab to 0368699 Aug 12, 2019

@njgheorghita

This comment has been minimized.

Copy link
Contributor Author

commented Aug 12, 2019

@pipermerriam Definitely, a little suspicious about how it went this long without getting a test but it's there now.

@njgheorghita njgheorghita force-pushed the njgheorghita:ethpm-fix-regex branch from 0368699 to df0df59 Aug 12, 2019

@pipermerriam
Copy link
Member

left a comment

👍

(if you didn't, you should verify that the expected tests do indeed fail without this patch before merging to be extra sure everything is behaving as expected)

@njgheorghita njgheorghita merged commit 4b146df into ethereum:master Aug 12, 2019

28 checks passed

ci/circleci: doctest Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: py36-core Your tests passed on CircleCI!
Details
ci/circleci: py36-ens Your tests passed on CircleCI!
Details
ci/circleci: py36-ethpm Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-ethtester-pyevm Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-http-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-http-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ipc-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ipc-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ws-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ws-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-parity-http Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-parity-ipc Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-parity-ws Your tests passed on CircleCI!
Details
ci/circleci: py37-core Your tests passed on CircleCI!
Details
ci/circleci: py37-ens Your tests passed on CircleCI!
Details
ci/circleci: py37-ethpm Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-ethtester-pyevm Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-http-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-http-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ipc-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ipc-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ws-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ws-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-parity-http Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-parity-ipc Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-parity-ws Your tests passed on CircleCI!
Details

@njgheorghita njgheorghita deleted the njgheorghita:ethpm-fix-regex branch Aug 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.