Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ethpm contract types property #1440

Merged

Conversation

@njgheorghita
Copy link
Contributor

commented Aug 29, 2019

What was wrong?

  • Added a Package.contract_types property to easily access all available contract types in a package.
  • Consolidated Package.from_uri tests

Todo:

Cute Animal Picture

image

@njgheorghita njgheorghita force-pushed the njgheorghita:ethpm-contract-types-property branch 3 times, most recently from de818a4 to eac39c9 Aug 29, 2019

@njgheorghita njgheorghita force-pushed the njgheorghita:ethpm-contract-types-property branch from eac39c9 to 8989750 Aug 29, 2019

@njgheorghita njgheorghita requested review from kclowes and pipermerriam Aug 29, 2019

@kclowes
Copy link
Contributor

left a comment

Looks good to me!

for deployment_name, deployment_data in deployments.items():
if deployment_data['contract_type'] not in contract_types:
if deployment_data['contract_type'] not in self.contract_types:

This comment has been minimized.

Copy link
@kclowes

kclowes Aug 29, 2019

Contributor

Will you always have deployment data here? If not, it's probably worth a check:

if deployment_data and deployment_data['contract_type'] not in self.contract_types:
    ...

This comment has been minimized.

Copy link
@njgheorghita

njgheorghita Aug 29, 2019

Author Contributor

Ahh good thought - but we check for deployments on line 346 / so if people are using this private method correctly (via Package.deployments and not directly ) then we should be ok

@njgheorghita njgheorghita merged commit abb0e41 into ethereum:master Aug 29, 2019

28 checks passed

ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: py36-core Your tests passed on CircleCI!
Details
ci/circleci: py36-ens Your tests passed on CircleCI!
Details
ci/circleci: py36-ethpm Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-ethtester-pyevm Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-http-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-http-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ipc-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ipc-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ws-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ws-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-parity-http Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-parity-ipc Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-parity-ws Your tests passed on CircleCI!
Details
ci/circleci: py37-core Your tests passed on CircleCI!
Details
ci/circleci: py37-ens Your tests passed on CircleCI!
Details
ci/circleci: py37-ethpm Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-ethtester-pyevm Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-http-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-http-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ipc-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ipc-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ws-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ws-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-parity-http Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-parity-ipc Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-parity-ws Your tests passed on CircleCI!
Details

@njgheorghita njgheorghita deleted the njgheorghita:ethpm-contract-types-property branch Aug 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.