Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async formatters #1461

Merged
merged 7 commits into from Nov 13, 2019
Merged

Async formatters #1461

merged 7 commits into from Nov 13, 2019

Conversation

@kclowes
Copy link
Contributor

kclowes commented Sep 26, 2019

What was wrong?

Updates #1209 to most recent master since it was opened so long ago.

Related to Issue #1413

How was it fixed?

Pulled in master and updated tests.

Todo:

Cute Animal Picture

image

@kclowes kclowes force-pushed the kclowes:async-api-formatters-ii branch 2 times, most recently from 99c3f2b to b385c2c Sep 26, 2019
@kclowes kclowes changed the title [WIP] Async formatters Async formatters Sep 27, 2019
web3/_utils/method_formatters.py Outdated Show resolved Hide resolved
web3/_utils/method_formatters.py Show resolved Hide resolved
tests/core/method-class/test_result_formatters.py Outdated Show resolved Hide resolved
@kclowes kclowes changed the title Async formatters [WIP] Async formatters Sep 27, 2019
@kclowes kclowes force-pushed the kclowes:async-api-formatters-ii branch from fe8c0c6 to ebe5b19 Nov 1, 2019
@kclowes kclowes force-pushed the kclowes:async-api-formatters-ii branch 5 times, most recently from 026dd77 to 1740e3a Nov 1, 2019
@kclowes kclowes force-pushed the kclowes:async-api-formatters-ii branch from 81a2bac to 4d2a0d4 Nov 11, 2019
@kclowes kclowes changed the title [WIP] Async formatters Async formatters Nov 11, 2019
@kclowes kclowes requested a review from pipermerriam Nov 11, 2019
Copy link
Member

pipermerriam left a comment

👍 keep an eye out for more areas where code is not intuitive and finding ways to drop in some larger comments that try and explain things in a more natural way.

web3/manager.py Outdated Show resolved Hide resolved
except TypeError:
raise ValueError("input_munger expects a 3-tuple")

def input_munger(self, module, args, kwargs):
# TODO: Create friendly error output.
mungers_iter = iter(self.mungers)
root_munger = next(mungers_iter)

This comment has been minimized.

Copy link
@pipermerriam

pipermerriam Nov 11, 2019

Member

I know this code wasn't changed, but it strikes me as something that is in need of a nice comment explaining what it is doing as it is quite cryptic at-a-glance.

@kclowes kclowes force-pushed the kclowes:async-api-formatters-ii branch from 3b62fb3 to 8db82b2 Nov 13, 2019
kclowes added a commit to kclowes/web3.py that referenced this pull request Nov 13, 2019
@kclowes kclowes force-pushed the kclowes:async-api-formatters-ii branch from 8db82b2 to 71ba5f1 Nov 13, 2019
@kclowes kclowes force-pushed the kclowes:async-api-formatters-ii branch from 71ba5f1 to 9f7c882 Nov 13, 2019
@kclowes kclowes force-pushed the kclowes:async-api-formatters-ii branch from 9f7c882 to a103b60 Nov 13, 2019
@kclowes kclowes merged commit f55f563 into ethereum:master Nov 13, 2019
42 checks passed
42 checks passed
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: py36-core Your tests passed on CircleCI!
Details
ci/circleci: py36-ens Your tests passed on CircleCI!
Details
ci/circleci: py36-ethpm Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-ethtester-pyevm Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-http-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-http-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ipc-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ipc-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ws-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ws-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-parity-http Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-parity-ipc Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-parity-ws Your tests passed on CircleCI!
Details
ci/circleci: py37-core Your tests passed on CircleCI!
Details
ci/circleci: py37-ens Your tests passed on CircleCI!
Details
ci/circleci: py37-ethpm Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-ethtester-pyevm Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-http-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-http-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ipc-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ipc-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ws-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ws-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-parity-http Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-parity-ipc Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-parity-ws Your tests passed on CircleCI!
Details
ci/circleci: py38-core Your tests passed on CircleCI!
Details
ci/circleci: py38-ens Your tests passed on CircleCI!
Details
ci/circleci: py38-ethpm Your tests passed on CircleCI!
Details
ci/circleci: py38-integration-ethtester-pyevm Your tests passed on CircleCI!
Details
ci/circleci: py38-integration-goethereum-http-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py38-integration-goethereum-http-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py38-integration-goethereum-ipc-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py38-integration-goethereum-ipc-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py38-integration-goethereum-ws-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py38-integration-goethereum-ws-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py38-integration-parity-http Your tests passed on CircleCI!
Details
ci/circleci: py38-integration-parity-ipc Your tests passed on CircleCI!
Details
ci/circleci: py38-integration-parity-ws Your tests passed on CircleCI!
Details
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
@kclowes kclowes deleted the kclowes:async-api-formatters-ii branch Nov 13, 2019
@kclowes kclowes mentioned this pull request Nov 21, 2019
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.