Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add quickest infura instructions #1482

Merged
merged 6 commits into from Nov 7, 2019
Merged

add quickest infura instructions #1482

merged 6 commits into from Nov 7, 2019

Conversation

@jschiarizzi
Copy link
Contributor

jschiarizzi commented Oct 28, 2019

What was wrong?

The quick start was not quick enough. Several python developers I recommended it to were stuck on connecting a node. The quick start example required users to look through docs elsewhere (bad user experience, most will quit at this step) in order to connect to a provider.

Related to Issue #1481

How was it fixed?

Added explanation of Infura and setting Infura global variable to quick start docs.

Todo:

Cute Animal Picture (my puppy Stella)

1021191535_HDR

Copy link
Contributor

kclowes left a comment

Thank you @jschiarizzi! @pipermerriam any feedback here?

docs/quickstart.rst Outdated Show resolved Hide resolved
docs/quickstart.rst Show resolved Hide resolved
jschiarizzi added 2 commits Oct 28, 2019
@jschiarizzi

This comment has been minimized.

Copy link
Contributor Author

jschiarizzi commented Oct 29, 2019

oof now i'm failing a check... Let's see if I can fix it not.

@jschiarizzi

This comment has been minimized.

Copy link
Contributor Author

jschiarizzi commented Oct 29, 2019

Great, looks like the checks are passing now. I never made a .rst file before so that syntax took a hot minute to figure out. :) Should be good for a merge now @kclowes

This ``w3`` instance will now allow you to interact with the Ethereum
blockchain.

.. NOTE::

This comment has been minimized.

Copy link
@kclowes

kclowes Nov 4, 2019

Contributor

Any objections to the updated wording @jschiarizzi?

@kclowes
kclowes approved these changes Nov 7, 2019
@kclowes

This comment has been minimized.

Copy link
Contributor

kclowes commented Nov 7, 2019

Thanks @jschiarizzi! Feel free to open another PR if you don't like my updates :)

@kclowes kclowes merged commit c4b2493 into ethereum:master Nov 7, 2019
29 checks passed
29 checks passed
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: py36-core Your tests passed on CircleCI!
Details
ci/circleci: py36-ens Your tests passed on CircleCI!
Details
ci/circleci: py36-ethpm Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-ethtester-pyevm Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-http-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-http-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ipc-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ipc-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ws-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ws-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-parity-http Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-parity-ipc Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-parity-ws Your tests passed on CircleCI!
Details
ci/circleci: py37-core Your tests passed on CircleCI!
Details
ci/circleci: py37-ens Your tests passed on CircleCI!
Details
ci/circleci: py37-ethpm Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-ethtester-pyevm Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-http-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-http-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ipc-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ipc-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ws-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ws-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-parity-http Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-parity-ipc Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-parity-ws Your tests passed on CircleCI!
Details
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
@jschiarizzi

This comment has been minimized.

Copy link
Contributor Author

jschiarizzi commented Nov 8, 2019

Looking good, thanks. Sorry I didn't comment, busy week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.