Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ethpm] Support ENS in Registry URIs #1489

Merged

Conversation

@njgheorghita
Copy link
Contributor

njgheorghita commented Nov 1, 2019

What was wrong?

ENS support was needed in ERC1319 URIs.

Todo:

Cute Animal Picture

image

@njgheorghita njgheorghita changed the title Support ens in Registry URIs [ethpm] Support ENS in Registry URIs Nov 1, 2019
@njgheorghita njgheorghita force-pushed the njgheorghita:ethpm-support-ens-in-registry-uri branch 3 times, most recently from fc89b2a to 3c99fcb Nov 1, 2019
@njgheorghita njgheorghita requested a review from pipermerriam Nov 1, 2019
@njgheorghita

This comment has been minimized.

Copy link
Contributor Author

njgheorghita commented Nov 7, 2019

ping @pipermerriam for 👀

if ns.address(address_or_ens):
address = ns.address(address_or_ens)
ens = address_or_ens
elif is_address(address_or_ens):

This comment has been minimized.

Copy link
@pipermerriam

pipermerriam Nov 7, 2019

Member

Seems like you might want this one to come first in the if/elif ordering since it's a simpler check and might be the more common case.

@@ -78,11 +82,23 @@ def parse_registry_uri(uri: str) -> RegistryURI:
"""
Validate and return (authority, pkg name, version) from a valid registry URI
"""
from web3.auto.infura import w3

This comment has been minimized.

Copy link
@pipermerriam

pipermerriam Nov 7, 2019

Member

It would be ideal if we could setup a test chain and install the ENS infrastructure on it easily so that we could test this stuff locally without hitting infura. Maybe that's a project for the Web3.py codebase to support under something like web3.tools for doing one-step setup of all of the ENS contracts on a development chain.

@njgheorghita njgheorghita force-pushed the njgheorghita:ethpm-support-ens-in-registry-uri branch from 3c99fcb to f263445 Nov 8, 2019
@njgheorghita njgheorghita merged commit f4bac7f into ethereum:master Nov 8, 2019
29 checks passed
29 checks passed
ci/circleci: docs Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: py36-core Your tests passed on CircleCI!
Details
ci/circleci: py36-ens Your tests passed on CircleCI!
Details
ci/circleci: py36-ethpm Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-ethtester-pyevm Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-http-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-http-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ipc-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ipc-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ws-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-goethereum-ws-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-parity-http Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-parity-ipc Your tests passed on CircleCI!
Details
ci/circleci: py36-integration-parity-ws Your tests passed on CircleCI!
Details
ci/circleci: py37-core Your tests passed on CircleCI!
Details
ci/circleci: py37-ens Your tests passed on CircleCI!
Details
ci/circleci: py37-ethpm Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-ethtester-pyevm Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-http-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-http-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ipc-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ipc-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ws-1.7.2 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-goethereum-ws-1.8.22 Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-parity-http Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-parity-ipc Your tests passed on CircleCI!
Details
ci/circleci: py37-integration-parity-ws Your tests passed on CircleCI!
Details
continuous-documentation/read-the-docs Read the Docs build succeeded!
Details
@njgheorghita njgheorghita deleted the njgheorghita:ethpm-support-ens-in-registry-uri branch Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.