Using set(EXECUTABLE testweb3) to bring the CMake file for the libweb… #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…three tests in line with the other files. This also fixes automated dependency graph generation.
|
build failing? |
|
I can't see the logs, @gavofyork. Please could you cut-and-paste one? I assume they are all the same? |
| @@ -28,8 +28,7 @@ using namespace dev; | |||
| using namespace dev::p2p; | |||
| using namespace dev::shh; | |||
|
|
|||
| WhisperPeer::WhisperPeer(std::shared_ptr<Session> _s, HostCapabilityFace* _h, unsigned _i, CapDesc const&, uint16_t _capID): | |||
There was a problem hiding this comment.
Trying to work out where the break came. It's not from my edits.
Build fails. Undo. Build fails. Redo. Build succeeds.
Sad face. That took a lot of hours :-(
@LefterisJP @gavofyork @chriseth.
Anyway - end result is this PR is now ready for merge, fixing the solidity module name inconsistency and the missing set(EXECUTABLE testweb3), now with some bonus messy history.
LefterisJP
added a commit
that referenced
this issue
Dec 4, 2015
Using set(EXECUTABLE testweb3) to bring the CMake file for the libweb…
|
Thanks, @LefterisJP, and also for the PR-for-my-PR! Nearly there, eh? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
…three tests in line with the other files.
This also fixes automated dependency graph generation.