New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using set(EXECUTABLE testweb3) to bring the CMake file for the libweb… #88
Conversation
…three tests in line with the other files. This also fixes automated dependency graph generation.
build failing? |
I can't see the logs, @gavofyork. Please could you cut-and-paste one? I assume they are all the same? |
@@ -28,8 +28,7 @@ using namespace dev; | |||
using namespace dev::p2p; | |||
using namespace dev::shh; | |||
|
|||
WhisperPeer::WhisperPeer(std::shared_ptr<Session> _s, HostCapabilityFace* _h, unsigned _i, CapDesc const&, uint16_t _capID): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the reversion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to work out where the break came. It's not from my edits.
Build fails. Undo. Build fails. Redo. Build succeeds.
Sad face. That took a lot of hours :-(
@LefterisJP @gavofyork @chriseth.
Anyway - end result is this PR is now ready for merge, fixing the solidity module name inconsistency and the missing set(EXECUTABLE testweb3), now with some bonus messy history.
Using set(EXECUTABLE testweb3) to bring the CMake file for the libweb…
Thanks, @LefterisJP, and also for the PR-for-my-PR! Nearly there, eh? |
…three tests in line with the other files.
This also fixes automated dependency graph generation.