Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upUsing set(EXECUTABLE testweb3) to bring the CMake file for the libweb… #88
Conversation
LefterisJP
added
the
looks good
label
Dec 3, 2015
bobsummerwill
referenced this pull request
in ethereum/solidity
Dec 3, 2015
Merged
Corrected case for Solidity library entry in CMake file. #274
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
build failing? |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bobsummerwill
Dec 3, 2015
Contributor
I can't see the logs, @gavofyork. Please could you cut-and-paste one? I assume they are all the same?
|
I can't see the logs, @gavofyork. Please could you cut-and-paste one? I assume they are all the same? |
bobsummerwill
added some commits
Dec 4, 2015
subtly
reviewed
Dec 4, 2015
View changes
| @@ -28,8 +28,7 @@ using namespace dev; | ||
| using namespace dev::p2p; | ||
| using namespace dev::shh; | ||
| -WhisperPeer::WhisperPeer(std::shared_ptr<Session> _s, HostCapabilityFace* _h, unsigned _i, CapDesc const&, uint16_t _capID): |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bobsummerwill
Dec 4, 2015
Contributor
Trying to work out where the break came. It's not from my edits.
Build fails. Undo. Build fails. Redo. Build succeeds.
Sad face. That took a lot of hours :-(
@LefterisJP @gavofyork @chriseth.
Anyway - end result is this PR is now ready for merge, fixing the solidity module name inconsistency and the missing set(EXECUTABLE testweb3), now with some bonus messy history.
bobsummerwill
Dec 4, 2015
Contributor
Trying to work out where the break came. It's not from my edits.
Build fails. Undo. Build fails. Redo. Build succeeds.
Sad face. That took a lot of hours :-(
@LefterisJP @gavofyork @chriseth.
Anyway - end result is this PR is now ready for merge, fixing the solidity module name inconsistency and the missing set(EXECUTABLE testweb3), now with some bonus messy history.
added a commit
that referenced
this pull request
Dec 4, 2015
LefterisJP
merged commit 55263dd
into
ethereum:develop
Dec 4, 2015
7 checks passed
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
bobsummerwill
Dec 4, 2015
Contributor
Thanks, @LefterisJP, and also for the PR-for-my-PR! Nearly there, eh?
|
Thanks, @LefterisJP, and also for the PR-for-my-PR! Nearly there, eh? |
bobsummerwill commentedDec 3, 2015
…three tests in line with the other files.
This also fixes automated dependency graph generation.