New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing #ifdefs to eth and flu main.cpp files #89

Merged
merged 2 commits into from Dec 15, 2015

Conversation

Projects
None yet
3 participants
@bobsummerwill
Contributor

bobsummerwill commented Dec 6, 2015

Added missing #ifdefs to eth and flu main.cpp files, both of which contained unconditional use of the JSRemoteConsole class even when JSCONSOLE is disabled.

bobsummerwill added some commits Dec 6, 2015

Added missing #ifdefs to eth and flu main.cpp files, both of which co…
…ntained unconditional use of the JSRemoteConsole class even when JSCONSOLE is disabled.
@bobsummerwill

This comment has been minimized.

Show comment
Hide comment
@bobsummerwill

bobsummerwill Dec 15, 2015

Contributor

Hey @LefterisJP, @chriseth, @gavofyork - Please could we get this merged? Thanks!

Contributor

bobsummerwill commented Dec 15, 2015

Hey @LefterisJP, @chriseth, @gavofyork - Please could we get this merged? Thanks!

@LefterisJP

This comment has been minimized.

Show comment
Hide comment
@LefterisJP

LefterisJP Dec 15, 2015

Contributor

Will wait for 1more guy to look at this before merging

Contributor

LefterisJP commented Dec 15, 2015

Will wait for 1more guy to look at this before merging

@bobsummerwill

This comment has been minimized.

Show comment
Hide comment
@bobsummerwill

bobsummerwill Dec 15, 2015

Contributor

np. Thanks!

Contributor

bobsummerwill commented Dec 15, 2015

np. Thanks!

chriseth added a commit that referenced this pull request Dec 15, 2015

Merge pull request #89 from doublethinkco/fix_main_conditional
Added missing #ifdefs to eth and flu main.cpp files

@chriseth chriseth merged commit adc57d6 into ethereum:develop Dec 15, 2015

7 checks passed

macosx_slave The build has succeeded
Details
macosx_slave-tests The Tests run succeeded
Details
ubuntu The build has succeeded
Details
ubuntu-tests The Tests run succeeded
Details
webthree -- ALL Build finished. No test results found.
Details
windows-slave The build has succeeded
Details
windows-slave-tests The Tests run succeeded
Details
@bobsummerwill

This comment has been minimized.

Show comment
Hide comment
@bobsummerwill

bobsummerwill Dec 15, 2015

Contributor

Great ... I think that's everything I have pending for now. Thanks, gents!

Contributor

bobsummerwill commented Dec 15, 2015

Great ... I think that's everything I have pending for now. Thanks, gents!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment