Remove the modulo 2^{256} effect in the memory size computation #185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds notes to MLOAD, MSTORE and MSTORE8 specification
saying the modulo is not considered when computing the new memory
size.
Before this change, since the beginning of the table contains
`All arithmetic is modulo $2^{256}$ unless otherwise noted.`,
the memory size computation was affected by the modulo computation too.
For instance, MLOAD with the biggest uint256 didn't change the memory size
most of the time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds notes to MLOAD, MSTORE and MSTORE8 specification saying the modulo is not considered when computing the new memory size.
Before this change, since the beginning of the table contains
All arithmetic is modulo $2^{256}$ unless otherwise noted., the memory size computation was affected by the modulo computation too. For instance, MLOAD with the biggest uint256 didn't change the memory size most of the time.By the way I checked that
cpp-ethereum,go-ethereumandpyethereumall throw out-of-gas for such an instruction.