Fix mistakes in DELEGATECALL semantics#187
Merged
gavofyork merged 2 commits intoethereum:masterfrom Oct 12, 2016
Merged
Conversation
Before this commit, the semantics of DELEGATECALL referred to `\mu_s[2]`. However, this argument is omitted from DELEGATECALL. Instead, the semantics should refer to `I_v`, which is the current "value".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes two problems in the
DELEGATECALLsemantics.DELEGATECALLreferred to the stack elementμₛ[2]. However, this element is exactly the one that is available forCALLbut removed forDELEGATECALL. Instead, the definition should refer toIᵥ.DELEGATECALLdid not explain why it takes one fewer arguments thanCALL. This pull-request adds the explanation and a remark about re-interpreting all the following arguments.