Pass a bit as the second argument of HP.#749
Merged
acoglio merged 1 commit intoethereum:masterfrom May 12, 2019
Merged
Conversation
Appendix D was passing true and false as the second argument t of HP. However, HP (and f) in Appendix C treat t as a bit, not as a boolean. Even though bits and booleans are isomoprhic, it's clearer to change Appendix D to pass bits. The mention of true and false in the text that precedes eq. (194) has also been changes to 1 and 0.
nicksavers
approved these changes
May 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appendix D was passing true and false as the second argument t of HP. However,
HP (and f) in Appendix C treat t as a bit, not as a boolean. Even though bits
and booleans are isomoprhic, it's clearer to change Appendix D to pass bits. The
mention of true and false in the text that precedes eq. (194) has also been
changes to 1 and 0.
This changes
to
This is an alternative PR to #747. One way or the other, Appendices C and D should be consistent in their treatment of the t argument of HP (and f).