Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass a bit as the second argument of HP. #749

Merged
merged 1 commit into from
May 12, 2019
Merged

Conversation

acoglio
Copy link
Member

@acoglio acoglio commented May 8, 2019

Appendix D was passing true and false as the second argument t of HP. However,
HP (and f) in Appendix C treat t as a bit, not as a boolean. Even though bits
and booleans are isomoprhic, it's clearer to change Appendix D to pass bits. The
mention of true and false in the text that precedes eq. (194) has also been
changes to 1 and 0.

This changes
old-hp-bit
to
new-hp-bit

This is an alternative PR to #747. One way or the other, Appendices C and D should be consistent in their treatment of the t argument of HP (and f).

Appendix D was passing true and false as the second argument t of HP. However,
HP (and f) in Appendix C treat t as a bit, not as a boolean. Even though bits
and booleans are isomoprhic, it's clearer to change Appendix D to pass bits. The
mention of true and false in the text that precedes eq. (194) has also been
changes to 1 and 0.
@acoglio acoglio merged commit 5bcd9e1 into ethereum:master May 12, 2019
@acoglio acoglio deleted the hp-bit branch June 3, 2020 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants