Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace defineProperties with explicit type-safe alternative #29

Open
s1na opened this issue Jan 9, 2019 · 0 comments
Open

Replace defineProperties with explicit type-safe alternative #29

s1na opened this issue Jan 9, 2019 · 0 comments

Comments

@s1na
Copy link
Contributor

@s1na s1na commented Jan 9, 2019

After the transition to typescript, a possible improvement would be to replace defineProperties which defines attributes on the class implicitly with a more explicit type-safe alternative. Note that defineProperties is used in other repositories as well, and the solution should take this into consideration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.