Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes building files unnecessary to run tests #143

Merged
merged 2 commits into from Feb 3, 2020
Merged

Makes building files unnecessary to run tests #143

merged 2 commits into from Feb 3, 2020

Conversation

@evertonfraga
Copy link
Member

evertonfraga commented Jan 22, 2020

Normalizing effort based on this comment.

It uses ts-node for testing, requiring from src instead of dist.

@evertonfraga

This comment has been minimized.

Copy link
Member Author

evertonfraga commented Jan 23, 2020

There's an issue with coverage reporting. I'll fix and put for review again

@holgerd77

This comment has been minimized.

Copy link
Member

holgerd77 commented Jan 27, 2020

👍

@github-actions

This comment has been minimized.

Copy link

github-actions bot commented Feb 3, 2020

Coverage Status

Coverage decreased (-0.2%) to 90.909% when pulling 609f955 on ts-test into e0a66d7 on master.

@evertonfraga

This comment has been minimized.

Copy link
Member Author

evertonfraga commented Feb 3, 2020

Up for review again.

@ryanio
ryanio approved these changes Feb 3, 2020
Copy link
Contributor

ryanio left a comment

LGTM, tests ran fine on my local machine :)

@evertonfraga evertonfraga merged commit adcd290 into master Feb 3, 2020
16 checks passed
16 checks passed
coverage
Details
coverage
Details
lint
Details
lint
Details
test (8.x)
Details
test (8.x)
Details
test (10.x)
Details
test (10.x)
Details
test (12.x)
Details
test (12.x)
Details
test (13.x)
Details
test (13.x)
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.2%) to 90.909%
Details
@evertonfraga evertonfraga deleted the ts-test branch Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.