client: add missing tx fields to getBlockByHash #1881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Tests are failing probably because the JSON fields now are extended. Could you also add a simple test that verifies that these parameters are available when this method is called? |
This comment was marked as off-topic.
This comment was marked as off-topic.
Done and done :-) |
jochem-brouwer
approved these changes
May 13, 2022
|
I compared the files touched here with the ones on the optimistic PR #1878, and this should be mergeable without causing too much hazzle, will do. |
g11tech
pushed a commit
that referenced
this pull request
May 24, 2022
* client: add missing tx fields to getBlockByHash * Add test for "includeTransactions" * Fix test * numbers to hex * DRY Co-authored-by: Ryan Ghods <ryan@ryanio.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1880 by adding additional fields to transaction bodies as specified by the JSON-RPC spec