Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rlp dep and readme badge style #238

Merged
merged 1 commit into from Feb 11, 2020
Merged

Update rlp dep and readme badge style #238

merged 1 commit into from Feb 11, 2020

Conversation

@ryanio
Copy link
Contributor

ryanio commented Feb 6, 2020

This PR:

  • Removes the freenode badge
  • Updates the badge style to default to match the gh actions badge
  • Bumps rlp to 2.2.4 (shouldn't affect anything because already covered under previous range ^2.2.3)
@ryanio ryanio force-pushed the updateReadmeBadges branch from aa0482a to cde98e0 Feb 6, 2020
@github-actions

This comment has been minimized.

Copy link

github-actions bot commented Feb 6, 2020

Coverage Status

Coverage remained the same at 99.645% when pulling cde98e0 on updateReadmeBadges into 73b67c6 on master.

@ryanio ryanio force-pushed the updateReadmeBadges branch from cde98e0 to b7e3acb Feb 6, 2020
@ethereumjs ethereumjs deleted a comment from github-actions bot Feb 6, 2020
@holgerd77

This comment has been minimized.

Copy link
Member

holgerd77 commented Feb 7, 2020

Ah, you couldn't know that but the freenode chat literally doesn't exist any more for years. Um. 😜

@ryanio

This comment has been minimized.

Copy link
Contributor Author

ryanio commented Feb 7, 2020

Haha oops, ok I will update the PR.

@ryanio ryanio force-pushed the updateReadmeBadges branch from b7e3acb to a7944e4 Feb 7, 2020
@ryanio ryanio changed the title Update readme badge style Update rlp dep and readme badge style Feb 7, 2020
Copy link
Member

holgerd77 left a comment

LGTM

@holgerd77 holgerd77 merged commit 3bbc948 into master Feb 11, 2020
6 checks passed
6 checks passed
test (8.x)
Details
test (10.x)
Details
test (12.x)
Details
test (13.x)
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
coverage/coveralls Coverage remained the same at 99.645%
Details
@holgerd77 holgerd77 deleted the updateReadmeBadges branch Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.