New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLOCKHASH is broken #169

Closed
axic opened this Issue Aug 11, 2017 · 0 comments

Comments

Projects
None yet
1 participant
@axic
Member

axic commented Aug 11, 2017

getBlockHash expects a Buffer:

But it always receives a Javascript number from the BLOCKHASH opcode: https://github.com/ethereumjs/ethereumjs-vm/blob/master/lib/opFns.js#L337

The reason it still works is due to ethereumjs-util in the background transform anything into Buffer before it converts them to number in bufferToInt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment