New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metro-Byzantium Working Branch #161

Merged
merged 62 commits into from Sep 25, 2017

Conversation

Projects
None yet
5 participants
@jwasinger
Member

jwasinger commented Jul 28, 2017

  • This is the working branch for the implementation of Metropolis EIPs.
  • If you'd like to help, check out ethereumjs/ethereumjs-lib on Gitter.
  • Please be careful when pushing changes to this branch, especially if it reverts the work of others. If you aren't sure what to do next, ask in Gitter!
@holgerd77

This comment has been minimized.

Show comment
Hide comment
@holgerd77

holgerd77 Aug 9, 2017

Member

Todo-List/Current status:

Member

holgerd77 commented Aug 9, 2017

Todo-List/Current status:

Show outdated Hide outdated lib/index.js
Show outdated Hide outdated package.json
Show outdated Hide outdated lib/opFns.js
@axic

This comment has been minimized.

Show comment
Hide comment
@axic

axic Aug 10, 2017

Member

@jwasinger can you please rebase?

Member

axic commented Aug 10, 2017

@jwasinger can you please rebase?

Show outdated Hide outdated lib/index.js
@axic

This comment has been minimized.

Show comment
Hide comment
@axic

axic Aug 18, 2017

Member

Should be using https://github.com/ethereumjs/rustbn.js (once ready) for the new ecc precompiles.

Member

axic commented Aug 18, 2017

Should be using https://github.com/ethereumjs/rustbn.js (once ready) for the new ecc precompiles.

var totalGas = results.gasUsed.addn(returnFee)
var totalGas = results.gasUsed
if (!results.runState.vmError) {
var returnFee = results.return.length * fees.createDataGas.v

This comment has been minimized.

@axic

axic Aug 18, 2017

Member

Should use a BN instance just in case.

@axic

axic Aug 18, 2017

Member

Should use a BN instance just in case.

Show outdated Hide outdated package.json
Show outdated Hide outdated lib/opFns.js

@holgerd77 holgerd77 changed the title from Metropolis Working Branch to Metro-Byzantium Working Branch Sep 18, 2017

@jwasinger jwasinger referenced this pull request Sep 21, 2017

Closed

[META] Byzantium Implementation Progress #209

19 of 20 tasks complete

jwasinger and others added some commits Jul 28, 2017

Added STATICCALL restrictions for state changing opcodes, corrected m…
…echanism to pass the static flag to subcalls

cdetrio and others added some commits Sep 8, 2017

@holgerd77

This needs a last update to package.json with the updated master branch dependencies, otherwise this can be merged.

@holgerd77

This comment has been minimized.

Show comment
Hide comment
@holgerd77

holgerd77 Sep 25, 2017

Member

@cdetrio at the time I made this change it fixed a test, is it clear that this is now set somewhere else?

Member

holgerd77 commented on 4a3c0f6 Sep 25, 2017

@cdetrio at the time I made this change it fixed a test, is it clear that this is now set somewhere else?

@cdetrio

This comment has been minimized.

Show comment
Hide comment
@cdetrio

cdetrio Sep 25, 2017

Contributor

@holgerd77 the commit ab90781 says there was no change in test failures. runState.lastReturned is set here

Contributor

cdetrio commented Sep 25, 2017

@holgerd77 the commit ab90781 says there was no change in test failures. runState.lastReturned is set here

@jwasinger jwasinger merged commit 45d73f0 into ethereumjs:master Sep 25, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment