New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardized VM Tracing #170

Closed
wants to merge 6 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@jwasinger
Member

jwasinger commented Aug 11, 2017

Adds a --JSONTrace cli flag to enable VM tracing using the new EVM trace standard: ethereum/tests#249

Currently a WIP until I fix output of gas cost calculations.

Show outdated Hide outdated tests/GeneralStateTestsRunner.js Outdated
Show outdated Hide outdated tests/GeneralStateTestsRunner.js Outdated
Show outdated Hide outdated tests/GeneralStateTestsRunner.js Outdated
@holgerd77

This comment has been minimized.

Show comment
Hide comment
@holgerd77

holgerd77 Aug 22, 2017

Member

Already asked this on Gitter, wouldn't simply using the --debug flag be sufficient and more intuitive?

Member

holgerd77 commented Aug 22, 2017

Already asked this on Gitter, wouldn't simply using the --debug flag be sufficient and more intuitive?

@jwasinger

This comment has been minimized.

Show comment
Hide comment
@jwasinger

jwasinger Aug 22, 2017

Member

Why would the debug flag be more intuitive? JSONTrace describes literally what the flag does. debug is less descriptive in my opinion. Also cpp-ethereum has a jsontrace flag.

Member

jwasinger commented Aug 22, 2017

Why would the debug flag be more intuitive? JSONTrace describes literally what the flag does. debug is less descriptive in my opinion. Also cpp-ethereum has a jsontrace flag.

@holgerd77

This comment has been minimized.

Show comment
Hide comment
@holgerd77

holgerd77 Aug 23, 2017

Member

A flag debug would be easier to remember and could be easier "discovered" by just trying by newbees. But your arguments are very valid as well, so let's just stay with JSONTrace (this can be used case-insensitive, can't it? Otherwise I would maybe lowercase it.)

Member

holgerd77 commented Aug 23, 2017

A flag debug would be easier to remember and could be easier "discovered" by just trying by newbees. But your arguments are very valid as well, so let's just stay with JSONTrace (this can be used case-insensitive, can't it? Otherwise I would maybe lowercase it.)

@axic

This comment has been minimized.

Show comment
Hide comment
@axic

axic Sep 7, 2017

Member

Replaced by #194.

Member

axic commented Sep 7, 2017

Replaced by #194.

@axic axic closed this Sep 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment