New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOG should not be negative, but result in 0 gas left #181

Merged
merged 1 commit into from Aug 17, 2017

Conversation

Projects
None yet
2 participants
@axic
Member

axic commented Aug 17, 2017

Strange that tests never catch this..

@axic axic added the in progress label Aug 17, 2017

@cdetrio

This comment has been minimized.

Show comment
Hide comment
@cdetrio

cdetrio Aug 17, 2017

Contributor

Tests don't catch this, maybe because runState is never accessed after the call frame throws?

Contributor

cdetrio commented Aug 17, 2017

Tests don't catch this, maybe because runState is never accessed after the call frame throws?

@axic axic merged commit 2716182 into master Aug 17, 2017

2 checks passed

ci/circleci Your tests passed on CircleCI!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@axic axic deleted the oog-nonnegative branch Aug 17, 2017

@axic axic removed the in progress label Aug 17, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment