Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Coveralls to Codecov #645

Closed
wants to merge 1 commit into from
Closed

Conversation

@ryanio
Copy link
Contributor

ryanio commented Jan 6, 2020

Unfortunately Coveralls does not have any support for monorepos or merging reports. There are some tools we can use to merge the reports before submitting to Coveralls however their UI won't give us any detailed insights other than a combined coverage number which is not very useful.

@evertonfraga found Codecov does have this feature, and it is supported well: Merging Reports

Codecov is also free for public repos.

This PR is an initial step to switch ethereumjs-vm to Codecov, and if liked and approved, I can apply it toward the other pending monorepo repos.

I also like Codecov bot's comments which are much more detailed than Coveralls. I believe @holgerd77 you can enable them by installing the Codecov Github App.

@evertonfraga

This comment has been minimized.

Copy link
Member

evertonfraga commented Jan 6, 2020

Another good thing about GitHub Actions is not needing to have a coveralls devDependency to upload the reports, so one dependency less for the project. 👍

@ryanio ryanio force-pushed the ryanio:codecov branch from eb52023 to b91aef5 Jan 6, 2020
@holgerd77

This comment has been minimized.

Copy link
Member

holgerd77 commented Jan 7, 2020

Hi, would be open for a switch, Codecov seems to be a well-enough established tool as well. Have now installed the app for this (and all other) repos. @ryanio is it possible to already trigger a coverage report comment for this PR?

@evertonfraga

This comment has been minimized.

Copy link
Member

evertonfraga commented Jan 7, 2020

trying to trigger the pr:open event

@evertonfraga evertonfraga reopened this Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.