Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from Coveralls to Codecov #646

Merged
merged 1 commit into from Jan 8, 2020
Merged

Switch from Coveralls to Codecov #646

merged 1 commit into from Jan 8, 2020

Conversation

@ryanio
Copy link
Contributor

ryanio commented Jan 7, 2020

(Successor to #645)

Due to codecov/codecov-action#29, it does not look like GH Actions can post to CodeCov on PRs from forks due to the inability to share secrets.

CircleCI does not need CODECOV_TOKEN, so this PR tests pushing the coverage reports using CircleCI.

Once codecov/codecov-action#29 is resolved, we can remove the use of CircleCI and re-enable .github/workflows/vm-coverage.yml with the proper fix.

@ryanio ryanio force-pushed the codecov branch 4 times, most recently from 514760b to 1d37cc5 Jan 7, 2020
@ryanio ryanio self-assigned this Jan 7, 2020
@ryanio ryanio force-pushed the codecov branch from 8bf6d91 to c0bfd45 Jan 7, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Jan 7, 2020

Codecov Report

❗️ No coverage uploaded for pull request base (master@e32f732). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #646   +/-   ##
========================================
  Coverage          ?   91.4%           
========================================
  Files             ?      31           
  Lines             ?    1978           
  Branches          ?     326           
========================================
  Hits              ?    1808           
  Misses            ?      90           
  Partials          ?      80
Flag Coverage Δ
#vm 91.4% <ø> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e32f732...e5c9415. Read the comment docs.

@ryanio

This comment has been minimized.

Copy link
Contributor Author

ryanio commented Jan 7, 2020

Looks like it's now working well pushing from circleci to codecov without needing a token to be set, so it will work on PRs from forks :) https://codecov.io/gh/ethereumjs/ethereumjs-vm/pulls

@holgerd77 if this looks good to merge, please update the check from ghactions-coverage to circleci-coverage and should be good to go!

@ryanio ryanio force-pushed the codecov branch from c0bfd45 to 7a0ce03 Jan 7, 2020
@ryanio ryanio force-pushed the codecov branch from 7a0ce03 to e5c9415 Jan 7, 2020
@holgerd77

This comment has been minimized.

Copy link
Member

holgerd77 commented Jan 8, 2020

Bildschirmfoto 2020-01-08 um 12 23 38

Just comparing the coverage results from Coveralls (right) and Codecov (left). Coverage is systematically lower on Codecov, I would guess that their metrics work a bit differently and there is a somewhat more strict count in place. Wouldn't make this a blocker, especially in this direction (lower count) this is relatively unproblematic since it doesn't give a false sense of security / good coverage.

Copy link
Member

holgerd77 left a comment

This is really great, thanks a lot @ryanio! Really looking forward to the new coverage reports, confident that this will have a significant effect on test quality / coverage considerations along with PRs. This went always a bit under radar (unless someone wanted explicitly improve the coverage), since the info was very much inconvenient to consume along the normal work flow. So: cool! 😄

@holgerd77 holgerd77 merged commit d5475fa into master Jan 8, 2020
11 checks passed
11 checks passed
label
Details
lint
Details
test-api
Details
test-state
Details
test-blockchain
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected.
Details
codecov/project No report found to compare against
Details
@holgerd77 holgerd77 deleted the codecov branch Jan 8, 2020
@evertonfraga

This comment has been minimized.

Copy link
Member

evertonfraga commented Jan 8, 2020

Regarding the lower percentage, although I don’t see it as a problem as well, we can test some other settings to see how it behaves.
https://docs.codecov.io/docs/codecovyml-reference#section-parsers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.