Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update labeler.yml #656

Merged
merged 2 commits into from Feb 6, 2020
Merged

Update labeler.yml #656

merged 2 commits into from Feb 6, 2020

Conversation

@evertonfraga
Copy link
Member

evertonfraga commented Feb 5, 2020

Fixes paths so it matches those for the monorepo structure. Reference: https://github.com/evertonfraga/ethereumjs-vm/tree/master/packages

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 5, 2020

Codecov Report

Merging #656 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #656   +/-   ##
======================================
  Coverage    91.4%   91.4%           
======================================
  Files          31      31           
  Lines        1978    1978           
  Branches      326     326           
======================================
  Hits         1808    1808           
  Misses         90      90           
  Partials       80      80
Flag Coverage Δ
#vm 91.4% <100%> (ø) ⬆️
Impacted Files Coverage Δ
lib/evm/interpreter.ts 98.48% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4671270...8b26cfb. Read the comment docs.

@ryanio
ryanio approved these changes Feb 5, 2020
Copy link
Member

holgerd77 left a comment

LGTM

@holgerd77 holgerd77 merged commit 599c2f4 into master Feb 6, 2020
11 checks passed
11 checks passed
label
Details
lint
Details
test-api
Details
test-state
Details
test-blockchain
Details
LGTM analysis: JavaScript No code changes detected
Details
LGTM analysis: Python No code changes detected
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 91.4%)
Details
codecov/project 91.4% (+0%) compared to 4671270
Details
Migration to monorepo automation moved this from In Progress to Done Feb 6, 2020
@holgerd77 holgerd77 deleted the fix-autolabeler branch Feb 6, 2020
@holgerd77

This comment has been minimized.

Copy link
Member

holgerd77 commented Feb 6, 2020

@evertonfraga Same question as for @ryanio on his account library PR: should I generally (respectively in most cases where I don't see some reasoning against) merge a PR after review or better to just approve and leave merging to you?

@holgerd77

This comment has been minimized.

Copy link
Member

holgerd77 commented Feb 6, 2020

(side note: Ryan already approved but had to re-approve after merging in the changes from master)

@evertonfraga

This comment has been minimized.

Copy link
Member Author

evertonfraga commented Feb 6, 2020

Right, I'd like to make use of the label combo pr: please review + pr: merge ready for PRs that can be merged right away after review. Otherwise, just approving is good. :)

@holgerd77

This comment has been minimized.

Copy link
Member

holgerd77 commented Feb 7, 2020

Ah, though I once introduced the labels throughout the last year I actually wasn't aware any more that we have this "merge ready" label. 😋 This is actually a nice and clean solution, maybe we can generally get this established a bit. Will try to apply this myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.