Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Running API tests with ts-node #658

Merged
merged 1 commit into from Feb 11, 2020
Merged

Running API tests with ts-node #658

merged 1 commit into from Feb 11, 2020

Conversation

@evertonfraga
Copy link
Member

evertonfraga commented Feb 11, 2020

This little change aims to allow cross-package tests using TypeScript + Lerna.

It solves the problem below, in the monorepo context:

image

@codecov

This comment has been minimized.

Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #658 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #658   +/-   ##
======================================
  Coverage    91.4%   91.4%           
======================================
  Files          31      31           
  Lines        1978    1978           
  Branches      326     326           
======================================
  Hits         1808    1808           
  Misses         90      90           
  Partials       80      80
Flag Coverage Δ
#vm 91.4% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 599c2f4...2eb3082. Read the comment docs.

@ryanio
ryanio approved these changes Feb 11, 2020
Copy link
Contributor

ryanio left a comment

LGTM 👍

@holgerd77

This comment has been minimized.

Copy link
Member

holgerd77 commented Feb 11, 2020

Will merge since PR is set to "merge ready".

@holgerd77 holgerd77 merged commit 1824cd0 into master Feb 11, 2020
11 checks passed
11 checks passed
label
Details
lint
Details
test-api
Details
test-state
Details
test-blockchain
Details
LGTM analysis: Python No code changes detected
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
ci/circleci: coverage Your tests passed on CircleCI!
Details
ci/circleci: install Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 599c2f4...2eb3082
Details
codecov/project 91.4% remains the same compared to 599c2f4
Details
@holgerd77 holgerd77 deleted the ts-node-api-tests branch Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.