fix: node start up to continue on bootstrapper error #2910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrekucci
reviewed
Apr 27, 2022
pkg/node/node.go
Outdated
| if err != nil { | ||
| return nil, fmt.Errorf("bootstrapper failed to fetch batch state: %w", err) | ||
| logger.Errorf("bootstrapper failed to fetch batch state: %w", err) |
mrekucci
approved these changes
Apr 27, 2022
acud
approved these changes
Apr 27, 2022
ldeffenb
suggested changes
Apr 27, 2022
| @@ -479,9 +479,9 @@ func NewBee(addr string, publicKey *ecdsa.PublicKey, signer crypto.Signer, netwo | |||
| libp2pPrivateKey, | |||
| o, | |||
| ) | |||
| logger.Infof("bootstrapper done, took %s", time.Since(start)) | |||
| logger.Infof("bootstrapper took %s", time.Since(start)) | |||
There was a problem hiding this comment.
Should this be bootstrapper or BatchState initialization?
There was a problem hiding this comment.
I tend to agree that bootstrapper is hard to understand without context. My suggestion would be postage snapshot syncing took %s because that would be consistent how the feature is called in the config (use-postage-snapshot).
| if err != nil { | ||
| return nil, fmt.Errorf("bootstrapper failed to fetch batch state: %w", err) | ||
| logger.Errorf("bootstrapper failed to fetch batch state: %v", err) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Motivation and context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):
This change is