Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

race in pss/TestProtocol #1363

Open
zelig opened this issue May 1, 2019 · 0 comments

Comments

Projects
1 participant
@zelig
Copy link

commented May 1, 2019

==================
WARNING: DATA RACE
Read at 0x00c000357da0 by goroutine 400:
  runtime.mapaccess1_faststr()
      /home/travis/.gimme/versions/go1.12.4.linux.amd64/src/runtime/map_faststr.go:12 +0x0
  github.com/ethereum/go-ethereum/swarm/pss.(*Protocol).Handle()
      /home/travis/gopath/src/github.com/ethereum/go-ethereum/swarm/pss/protocol.go:207 +0x285
  github.com/ethereum/go-ethereum/swarm/pss.(*Protocol).Handle-fm()
      /home/travis/gopath/src/github.com/ethereum/go-ethereum/swarm/pss/protocol.go:165 +0x99
  github.com/ethereum/go-ethereum/swarm/pss.(*Pss).executeHandlers()
      /home/travis/gopath/src/github.com/ethereum/go-ethereum/swarm/pss/pss.go:495 +0x2f6
  github.com/ethereum/go-ethereum/swarm/pss.(*Pss).process()
      /home/travis/gopath/src/github.com/ethereum/go-ethereum/swarm/pss/pss.go:469 +0x30f
  github.com/ethereum/go-ethereum/swarm/pss.(*Pss).handlePssMsg()
      /home/travis/gopath/src/github.com/ethereum/go-ethereum/swarm/pss/pss.go:423 +0xe76
  github.com/ethereum/go-ethereum/swarm/pss.(*Pss).handlePssMsg-fm()
      /home/travis/gopath/src/github.com/ethereum/go-ethereum/swarm/pss/pss.go:376 +0x6d
  github.com/ethereum/go-ethereum/p2p/protocols.(*Peer).handleIncoming()
      /home/travis/gopath/src/github.com/ethereum/go-ethereum/p2p/protocols/protocol.go:374 +0xa0e
  github.com/ethereum/go-ethereum/p2p/protocols.(*Peer).Run()
      /home/travis/gopath/src/github.com/ethereum/go-ethereum/p2p/protocols/protocol.go:232 +0x4c
  github.com/ethereum/go-ethereum/swarm/pss.(*Pss).Run()
      /home/travis/gopath/src/github.com/ethereum/go-ethereum/swarm/pss/pss.go:263 +0x250
  github.com/ethereum/go-ethereum/swarm/pss.(*Pss).Run-fm()
      /home/travis/gopath/src/github.com/ethereum/go-ethereum/swarm/pss/pss.go:258 +0x63
  github.com/ethereum/go-ethereum/p2p.(*Peer).startProtocols.func1()
      /home/travis/gopath/src/github.com/ethereum/go-ethereum/p2p/peer.go:361 +0x8d
Previous write at 0x00c000357da0 by goroutine 286:
  runtime.mapdelete_faststr()
      /home/travis/.gimme/versions/go1.12.4.linux.amd64/src/runtime/map_faststr.go:297 +0x0
  github.com/ethereum/go-ethereum/swarm/pss.(*Protocol).RemovePeer()
      /home/travis/gopath/src/github.com/ethereum/go-ethereum/swarm/pss/protocol.go:272 +0x250
  github.com/ethereum/go-ethereum/swarm/pss.testProtocol()
      /home/travis/gopath/src/github.com/ethereum/go-ethereum/swarm/pss/protocol_test.go:157 +0x226c
  testing.tRunner()
      /home/travis/.gimme/versions/go1.12.4.linux.amd64/src/testing/testing.go:865 +0x163
Goroutine 400 (running) created at:
  github.com/ethereum/go-ethereum/p2p.(*Peer).startProtocols()
      /home/travis/gopath/src/github.com/ethereum/go-ethereum/p2p/peer.go:360 +0x2c1
  github.com/ethereum/go-ethereum/p2p.(*Peer).run()
      /home/travis/gopath/src/github.com/ethereum/go-ethereum/p2p/peer.go:210 +0x164
  github.com/ethereum/go-ethereum/p2p.(*Server).runPeer()
      /home/travis/gopath/src/github.com/ethereum/go-ethereum/p2p/server.go:1002 +0x236
Goroutine 286 (running) created at:
  testing.(*T).Run()
      /home/travis/.gimme/versions/go1.12.4.linux.amd64/src/testing/testing.go:916 +0x65a
  github.com/ethereum/go-ethereum/swarm/pss.TestProtocol()
      /home/travis/gopath/src/github.com/ethereum/go-ethereum/swarm/pss/protocol_test.go:43 +0x8c
  testing.tRunner()
      /home/travis/.gimme/versions/go1.12.4.linux.amd64/src/testing/testing.go:865 +0x163
==================
WARN [04-27|18:20:41.872] caught subscription error in pss sub topic 7f64614e: <nil> caller=api.go:85
WARN [04-27|18:20:41.873] caught subscription error in pss sub topic 7f64614e: <nil> caller=api.go:85
WARN [04-27|18:20:41.878] Failed to start smart card hub, disabling: dial unix /run/pcscd/pcscd.comm: connect: no such file or directory caller=config.go:510
WARN [04-27|18:20:41.895] Failed to start smart card hub, disabling: dial unix /run/pcscd/pcscd.comm: connect: no such file or directory caller=config.go:510
WARN [04-27|18:20:43.020] caught subscription error in pss sub topic 7f64614e: <nil> caller=api.go:85
WARN [04-27|18:20:43.022] caught subscription error in pss sub topic 7f64614e: <nil> caller=api.go:85
--- FAIL: TestProtocol (3.36s)
    --- FAIL: TestProtocol/8 (1.13s)
        testing.go:809: race detected during execution of test
    testing.go:809: race detected during execution of test

@zelig zelig added bug test labels May 1, 2019

@zelig zelig added this to Backlog in Swarm via automation May 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.