Version 0.5.1 breaks is_print() if no page is requested #2

Open
ethitter opened this Issue Jun 4, 2012 · 1 comment

Comments

Projects
None yet
1 participant
@ethitter
Owner

ethitter commented Jun 4, 2012

get_query_var() returns an empty string regardless of whether or not the query var key appears in the array. When no specific print page is requested, this causes is_print() to fail.

See http://wordpress.org/support/topic/plugin-wp-print-friendly-redirects-back-to-original-article and http://www.thinkoomph.com/plugins-modules/wp-print-friendly/comment-page-3/#comment-71090

@ethitter

This comment has been minimized.

Show comment
Hide comment
@ethitter

ethitter Jun 6, 2012

Owner

Though ae71e6a fixed this problem, it still feels hacky to me to interact directly with WP_Query's query_vars array. I'll work on a better solution at some point.

Owner

ethitter commented Jun 6, 2012

Though ae71e6a fixed this problem, it still feels hacky to me to interact directly with WP_Query's query_vars array. I'll work on a better solution at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment