New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix signing error handling #3

wants to merge 1 commit into
base: master


None yet
2 participants

dukei commented Aug 28, 2017

Please apply this patch to fix the signing error handling. Without this patch any exception inside of signing function results in meaningless message:

Error: [ethjs-provider-signer] while signing your transaction payload: {}
at C:\project\module\node_modules\ethjs-provider-signer\lib\index.js:97

After this patch the calling application gets original error and ethjs-provider-signer message is logged to console.


This comment has been minimized.

coveralls commented Aug 28, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 5cdf2e1 on TiesNetwork:master into 0bdb4f4 on ethjs:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment