Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write build dependency mechanism for manifest building #167

Merged
merged 2 commits into from Jul 8, 2019

Conversation

Projects
None yet
2 participants
@njgheorghita
Copy link
Contributor

commented Jul 3, 2019

What was wrong?

builder tool needs a mechanism for adding build dependencies to a manifest.

Cute Animal Picture

image

@njgheorghita njgheorghita force-pushed the njgheorghita:builder-build-dependencies branch from 2a3dfc6 to 6da0d01 Jul 3, 2019

@njgheorghita njgheorghita force-pushed the njgheorghita:builder-build-dependencies branch from 6da0d01 to 3afbb82 Jul 3, 2019

@njgheorghita njgheorghita requested a review from pipermerriam Jul 3, 2019

),
)
assert actual_single == expected_single
assert actual_double == expected_double

This comment has been minimized.

Copy link
@pipermerriam

pipermerriam Jul 8, 2019

Member

This looks like it should be split into two tests.

@njgheorghita njgheorghita force-pushed the njgheorghita:builder-build-dependencies branch from f88ae39 to d0a725c Jul 8, 2019

@njgheorghita njgheorghita merged commit 147f5d7 into ethpm:master Jul 8, 2019

3 checks passed

ci/circleci: doctest Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: py36 Your tests passed on CircleCI!
Details

@njgheorghita njgheorghita deleted the njgheorghita:builder-build-dependencies branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.