Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update registry assets to include VersionRelease event #168

Merged
merged 1 commit into from Jul 8, 2019

Conversation

Projects
None yet
2 participants
@njgheorghita
Copy link
Contributor

commented Jul 8, 2019

What was wrong?

The ERC for registries was recently updated, along with the solidity reference implementation to include a VersionRelease event and some variable name changes. Stored assets in py-ethpm needed updating to reflect these changes.

Cute Animal Picture

image

@njgheorghita njgheorghita requested a review from pipermerriam Jul 8, 2019

@pipermerriam
Copy link
Member

left a comment

Seems like this shouldn't update the 1.0.0 release but instead be something like 2.0.0 since it's backwards incompatible with the change of the event name?

@njgheorghita njgheorghita force-pushed the njgheorghita:update-registry branch 9 times, most recently from 70404ca to 685c845 Jul 8, 2019

@njgheorghita njgheorghita force-pushed the njgheorghita:update-registry branch from 685c845 to 40cec84 Jul 8, 2019

@njgheorghita njgheorghita merged commit caa0b70 into ethpm:master Jul 8, 2019

3 checks passed

ci/circleci: doctest Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: py36 Your tests passed on CircleCI!
Details

@njgheorghita njgheorghita deleted the njgheorghita:update-registry branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.