Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update registry uri #169

Closed
wants to merge 2 commits into from

Conversation

@njgheorghita
Copy link
Contributor

commented Jul 11, 2019

What was wrong?

For the registry uri to be useful, it needs an idea of what chain the registry lives on, so I added the chain id to the registry uri definition.

erc1319://address:chain_id/package_name?version=1.0.0

IMO this will help out a lot with simplifying some of the ethpm-cli commands, since we want to support registries on testnets, and now the user only has to provide the uri to select the correct registry.

NOTE: This pr is located here for now, but will be moved to web3 asap

Cute Animal Picture

image

@njgheorghita

This comment has been minimized.

Copy link
Contributor Author

commented Jul 12, 2019

closing since pr has been moved to web3/ethpm ethereum/web3.py#1382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.