Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Matomo Tracking to Docs site. #170

Closed
wants to merge 1 commit into from

Conversation

@cburgdorf
Copy link
Contributor

cburgdorf commented Dec 6, 2019

What was wrong?

Currently we do not have a good insight into our target group. In order to improve both py-ethpm itself and the documentation, it makes sense to aggregate some data.

How was it fixed?

Add Matomo Tracking to Docs site.

Matomo is an Open Source web analytics platform that allows us
to get better insights and optimize for our audience without
the negative consequences of other compareable platforms.

Read more: https://matomo.org/why-matomo/

Cute Animal Picture

put a cute animal picture link inside the parentheses

@cburgdorf cburgdorf requested a review from njgheorghita Dec 6, 2019
@@ -89,6 +89,9 @@
# so a file named "default.css" will overwrite the builtin "default.css".
html_static_path = ['_static']

def setup(app):
app.add_js_file("js/matomo.js")

This comment has been minimized.

Copy link
@pipermerriam

pipermerriam Dec 6, 2019

Member

Looks like maybe you forgot to add the actual file?

This comment has been minimized.

Copy link
@cburgdorf

cburgdorf Dec 9, 2019

Author Contributor

Uh, yeah, and I also seem to have added a bunch of unrelated changes. Looks screwed up. Gonna fix it in a minute.

This comment has been minimized.

Copy link
@cburgdorf

cburgdorf Dec 9, 2019

Author Contributor

Ok, PR should be fixed.

@cburgdorf cburgdorf force-pushed the cburgdorf:christoph/feat/matomo branch from f0af396 to 757767c Dec 9, 2019
Matomo is an Open Source web analytics platform that allows us
to get better insights and optimize for our audience without
the negative consequences of other compareable platforms.

Read more: https://matomo.org/why-matomo/
@cburgdorf cburgdorf force-pushed the cburgdorf:christoph/feat/matomo branch from 757767c to 1b3ef89 Dec 9, 2019
@njgheorghita

This comment has been minimized.

Copy link
Contributor

njgheorghita commented Dec 9, 2019

@cburgdorf This repo is considered "deprecated" (though, this reminds me I should go through and mark so in the readme) in favor of the ethpm module in web3. The docs were also moved to the web3 repo. I'm not sure if it's worthwhile to gather data from this repo? But if you feel otherwise, I'm happy to merge this in.

@cburgdorf

This comment has been minimized.

Copy link
Contributor Author

cburgdorf commented Dec 9, 2019

Oh, good to know! I added https://py-ethpm.readthedocs.io to the Matomo Tracker but if that is being served directly from the web3 docs in the future than there's nothing left to do here. Closing.

@cburgdorf cburgdorf closed this Dec 9, 2019
@njgheorghita

This comment has been minimized.

Copy link
Contributor

njgheorghita commented Dec 10, 2019

@cburgdorf FYI - https://py-ethpm.readthedocs.io/ is being served from this repo - and is also being deprecated for the ethpm docs in web3 here, so it's probably worth removing the old docs link from matomo.

@cburgdorf

This comment has been minimized.

Copy link
Contributor Author

cburgdorf commented Dec 10, 2019

No problem. I pinged devops to remove it from the dashboard again (I can't do that myself)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.