Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue in --deprecated-skip-factor #80

Closed
shahvi opened this issue Jul 17, 2018 · 7 comments

Comments

Projects
None yet
2 participants
@shahvi
Copy link

commented Jul 17, 2018

It seems that the minimum freq these IMUs can deliver is 100Hz. For many applications this unnecessarily overloads the system. In our case we are using a 32 bit processor and the 100Hz IMU message calculation, publishing and rosbagging consumes over 90% of a core.
It would be a nice feature if the node would allow specifying a frequency (say 20 Hz) or a filtering factor (say every 5th message) and average messages (low pass filter) before publishing at a lower rate.

@fcolas

This comment has been minimized.

Copy link
Member

commented Jul 18, 2018

Well, I don't believe it fits in the driver.
First, you should be able to configure your device to output way lower rates than 100Hz. Did you try to do it (see the documentation of your IMU and/or of mtdevice.py)?
Second, there is already a generic ROS tool for throttling messages [1].
And third, the ROS (and UNIX) philosophy is more to have simpler nodes that perform a service well rather than a single big tool that tries to do everything. As such, if you want to apply a low-pass filter on your IMU measurement before recording it in a ROS bag, you should do it in a separate node.

In your case, with limited resource, the simplest seems to be to better configure your IMU.

[1] http://wiki.ros.org/topic_tools/throttle

@shahvi

This comment has been minimized.

Copy link
Author

commented Jul 18, 2018

@fcolas thanks for the info. Looks like I missed the skip-factor setting for the IMU. We have an old MTi with limited documentation. I think I have a couple ideas to try now.
Cheers.

@fcolas fcolas closed this Jul 19, 2018

@shahvi

This comment has been minimized.

Copy link
Author

commented Jul 23, 2018

@fcolas a quick question. I am trying to change our IMU frequency using the skip-factor option, but am not able to do it. The command I am using is:rosrun xsens_driver mtdevice.py -d /dev/ttyCTI1 -l --output-settings=tqMAG --output-mode=tcos --deprecated-skip-factor=4
However, this is not changing the frequency. Could you possibly point me in the right direction.

Doing a -i on our device shows

Device: /dev/ttyCTI1 at 115200 Bd:
  device ID:  0x01301262
  product code: 'MTi-28A53G35'
  firmware revision: (2, 6, 1)
  baudrate: 2
  error mode:  0x0001
  option flags:  message unsupported by your device.
  location ID:  0x0000
  transmit delay:  message unsupported by your device.
  synchronization settings:  message unsupported by your device.
  general configuration: {   'Master device ID': 19927650,
    'date': '\x00\x00\x00\x00\x00\x00\x00\x00',
    'device ID': 19927650,
    'length': 59,
    'number of devices': 1,
    'output-mode': 2055,
    'output-settings': 1,
    'period': 1152,
    'skipfactor': 0,
    'time': '\x00\x00\x00\x00\x00\x00\x00\x00'}
  output configuration (mark IV devices):  message unsupported by your device.
  string output type: 0
  period: 1152
  alignment rotation sensor:  message unsupported by your device.
  alignment rotation local:  message unsupported by your device.
  output mode:  0x0807
  extended output mode:  0x0000
  output settings:  0x00000001
  GPS coordinates (lat, lon, alt): (52.2404899597168, 6.838216781616211, 0.0)
  available scenarios: [   (4, 9, 'human'),
    (5, 9, 'human_large_accel'),
    (6, 9, 'machine'),
    (7, 9, 'machine_nomagfield'),
    (8, 9, 'marine')]
  current scenario ID: 5
  UTC time:  message unsupported by your device.

Thanks,

@fcolas

This comment has been minimized.

Copy link
Member

commented Aug 1, 2018

Well, the command line seems correct.
Could you try it again with the verbose -v flag and paste the full output here?

@shahvi

This comment has been minimized.

Copy link
Author

commented Aug 1, 2018

@fcolas I don't have the sensor with me, so won't be able to do that. However I was able to fix the issue by using the -f option instead. So the full command was rosrun xsens_driver mtdevice.py -d /dev/ttyCTI1 -l --output-settings=tqMAG --output-mode=tcos -f 4

@fcolas

This comment has been minimized.

Copy link
Member

commented Aug 1, 2018

Oops, it's a stupid command-line parsing bug. Many thanks for the catch!

@fcolas fcolas reopened this Aug 1, 2018

@fcolas fcolas added bug and removed enhancement wontfix labels Aug 1, 2018

@fcolas fcolas changed the title Suggest adding a software filter to reduce rate. Issue in --deprecated-skip-factor Aug 1, 2018

fcolas added a commit that referenced this issue Aug 2, 2018

@fcolas

This comment has been minimized.

Copy link
Member

commented Aug 2, 2018

Solved in b26e785

@fcolas fcolas closed this Aug 2, 2018

fcolas added a commit to fcolas/rosdistro that referenced this issue Aug 2, 2018

xsens_driver: 2.2.1-0 in 'kinetic/distribution.yaml'
Increasing version of package(s) in repository `xsens_driver` to `2.2.1-0`:

- upstream repository: https://github.com/ethz-asl/ethzasl_xsens_driver.git
- release repository: https://github.com/ethz-asl/ethzasl_xsens_driver-release.git
- distro file: `indigo/distribution.yaml`
- bloom version: `0.6.6`
- previous version for package: `2.2.0-0`

## xsens_driver

```
* fix frame reorientation (only for orientation and linear velocity)
* fix skip-factor command line (ros#80 <ethz-asl/ethzasl_xsens_driver#80>)
* Contributors: Francis Colas
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.