Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/configurable covariance diagonals #65

Merged
merged 5 commits into from Apr 4, 2018

Conversation

Projects
None yet
2 participants
@reinzor
Copy link
Contributor

commented Mar 21, 2018

Enables the user to alter the covariance of the various signals.

@fcolas

This comment has been minimized.

Copy link
Member

commented Mar 23, 2018

It's great, many thanks for your contribution. May I ask that you add those parameters in the launch file too?

@reinzor

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2018

Updated :)

@fcolas

This comment has been minimized.

Copy link
Member

commented Mar 23, 2018

Many thanks but it doesn't work for me: the test of line 38 fails, probably a conversion issue between the string representation and the actual list.

@reinzor

This comment has been minimized.

Copy link
Contributor Author

commented Mar 23, 2018

Sorry, I didn't test the launch file. I updated the launch file to use rosparam with subst_value=True, now the parameters are properly loaded via args of the launch file

@reinzor

This comment has been minimized.

Copy link
Contributor Author

commented Apr 2, 2018

ping :)

@fcolas

This comment has been minimized.

Copy link
Member

commented Apr 4, 2018

Many thanks for your contribution, it's greatly appreciated.

@fcolas fcolas merged commit 6d555ff into ethz-asl:master Apr 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.