New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(ISSUE #146) Adds license and long_description for pypi #154
Conversation
One other thing. I tried automatically adding the version from Couple of solutions I thought of:
The second solution is much cleaner IMO but it requires an extra file and it's up to you. This would mean you'd only need to update the version in that one place and you could have it import into setup.py for both version and for your download links. |
First solution is definitely not good idea. |
I agree with @charettes, I just included it because some other large projects use that. |
Your code will still be embedding markdown syntax in pypi. I suppose that's better than the broken ascii! What's the problem with from reversion import VERSION In any case, solution 2 is clearly better! |
|
Ah, I see. D'oh! If you can implement your solution 2, then I'll gladly pull this in. |
A little more hacky than I usually like to make sure everything is backwards compatible. |
@@ -0,0 +1 @@ | |||
__version__ = (1, 6, 0) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the version here? Isn't this just adding lines of code for no reason?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice markdown formatting error there. I mean __version__
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
__version__
is the PEP standard. Because you've used VERSION
every where else I didn't want to break backwards compatibility incase anyone is relying on VERSION
. http://www.python.org/dev/peps/pep-0396/
(ISSUE #146) Adds license and long_description for pypi
You're pulled! Many thanks! I've learned something today. :) |
This adds both the license and long_description to pypi.
It just uses the contents from LICENSE and README.markdown to populate these fields.