New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle non-caching of long tags properly #6

Merged
merged 1 commit into from Mar 25, 2016

Conversation

Projects
None yet
3 participants
@mmattice
Contributor

mmattice commented Mar 24, 2016

Separating this PR as #5 has some other issues, but this one should be mergable by itself. An example of the cache failure is in #5 as well.

@codecov-io

This comment has been minimized.

codecov-io commented Mar 24, 2016

Current coverage is 84.42%

Merging #6 into master will increase coverage by +0.01% as of 48fed69

@@            master      #6   diff @@
======================================
  Files           21      21       
  Stmts         2605    2607     +2
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit           2199    2201     +2
  Partial          0       0       
  Missed         406     406       

Review entire Coverage Diff as of 48fed69

Powered by Codecov. Updated on successful CI builds.

@etingof etingof merged commit 4732e13 into etingof:master Mar 25, 2016

2 checks passed

codecov/project 84.42% (+0.01%) compared to fefc649 at 84.41%
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

etingof added a commit that referenced this pull request Mar 25, 2016

nekolyanich added a commit to nekolyanich/pyasn1 that referenced this pull request Mar 28, 2017

Fix BitString initialization via namedValues
  class KeyUsage(BitString):
      namedValues = NamedValues(
          ('digitalSignature', 0),
          ('nonRepudiation', 1),
          ('keyEncipherment', 2),
          ('dataEncipherment', 3),
          ('keyAgreement', 4),
          ('keyCertSign', 5),
          ('cRLSign', 6),
          ('encipherOnly', 7),
          ('decipherOnly', 8),
      )

  encode(KeyUsage('keyCertSign,cRLSign')) != encode(KeyUsage("'0000011'B"))
                                                                    ^^
                                                                    ||
                                                bit etingof#5 -------------+|
                                                bit etingof#6 --------------+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment