New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test NET_AdrToString and associated code for IPv6 addresses / fix q3 net code merge #49
Comments
From: @JanSimek (Radegast) Ilm's patch which changed some occurances of NET_AdrToString to NET_AdrToStringwPort was reverted in commit:0e1679b0, but that is on the client side. |
From: @JanSimek (Radegast) ioquake3's @NET_AdrToString@ function was replaced by the original ET-GPL code in commit:d6ade049. This will possibly break some things, especially on the server side, so I'm not closing this bug report yet. |
From: @JanSimek (Radegast) All the occurrences of @NET_AdrToStringwPort@ were replaced with the older @NET_AdrToString@. The only remaining thing to do is to add port even for IPv6 addresses in @NET_AdrToString@. |
From: @IR4T4 (IR4T4) Note: The IPv4 is part of players' config string in the mod code and may break 2.60 compatibility if we just switch. |
From: @IR4T4 (IR4T4) {TODO} Replace gethostbyname() with getaddrinfo(). |
From: @IR4T4 (IR4T4) {TODO}
|
From: @IR4T4 (IR4T4) Currently all existing mods use IPv4 in playerinfo and configstrings. They can't deal with IPv6 IPs. For now there is no need to use IPv6. |
From: @IR4T4 (IR4T4) {TODO} Test IPv6 related code. |
Author: Trackbase (Trackbase)
Date: 2012-05-13
Redmine Issue: 49, https://dev.etlegacy.com/issues/49
The NET_AdrToString function is different then the one from ET:GPL (no port is added)
This results in problems with several mods that rely on an ip:port format in the userinfo.
This issue has been fixed by manually adding it, the main question stays however, does this affect more code? This needs checking...
Related issue(s): #501
Related commit(s):
d6ade04 - general: NET_AdrToString returns address with port..
48a14a3 - general: removed all occurrences of NET_AdrToStrin..
8bf9bc9 - generic: show IPv6 addresses using NET_AdrToString..
a2833e8 - client: NET_AdrToStringwPort replaced by NET_AdrTo..
The text was updated successfully, but these errors were encountered: