LapH #161

Open
ggscorzato opened this Issue Oct 4, 2012 · 9 comments

Comments

Projects
None yet
3 participants
Member

ggscorzato commented Oct 4, 2012

I plan to remove the option of LapH from the master branch and start a LapH-only branch. From LapH-only I will slowly remove what is not needed. The idea is that LapH-only should one day be merged into other analysis codes like Ahmidas or nissa.

Any comment?

Luigi

Contributor

urbach commented Oct 4, 2012

currently I'd really like to keep it in the main branch, as I'd like to use it, if that is possible.

Member

ggscorzato commented Oct 4, 2012

ok. I have used it and it works. You are welcome to use it.

Contributor

urbach commented Oct 4, 2012

and how?

Member

ggscorzato commented Oct 4, 2012

the code was broken, after—I believe—standardizing the complex in the rest of the code, which was not ported to all lapH routines. I have fixed it. Tomorrow I check how to commit (I haven't committed with git yet...)
I will also commit a typical LapH.input file with more instructions.

Contributor

urbach commented Oct 4, 2012

okay, would be great...

our procedure is that you prepare a branch with your changes in your own tmLQCD fork. Then you open a pull request which we discuss and check, before it will be included in the master branch...

Owner

kostrzewa commented Oct 5, 2012

I have also omitted OpenMP parallelization for many (or all) of the LapH routines because I didn't know if they were still in use and I already had hundreds of functions to worry about...

Member

ggscorzato commented Oct 5, 2012

I don't think that openMP parallelization is necessary for LapH. It is not as performance-critical as the rest. MPI parallelization was necessary, but it will be enough. It would be nice to add a check in the configure that openmp and laph are not enabled together.

I am going to make a pull request for some bug fixes in laph (I have to find out where to click in github ... :-) )

Owner

kostrzewa commented Oct 5, 2012

It would be nice to add a check in the configure that openmp and laph are not enabled together.

that's not strictly necessary, the parallelization doesn't affect correctness anyway, it would just make things slow when running on BG/Q say, because one thread will do the work of 64 threads...

Owner

kostrzewa commented Oct 5, 2012

I am going to make a pull request for some bug fixes in laph (I have to find out where to click in github ... :-) )

you have to navigate to your branch which contains the changes you wish to submit and click "create pull-request". There is also a convenience button on the main view of your fork which suggests creating a pull-request for your most recently pushed-to branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment